WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130433
Add new functionality that will be required by the history item decoding
https://bugs.webkit.org/show_bug.cgi?id=130433
Summary
Add new functionality that will be required by the history item decoding
Anders Carlsson
Reported
2014-03-18 16:55:08 PDT
Add new functionality that will be required by the history item decoding
Attachments
Patch
(5.14 KB, patch)
2014-03-18 16:56 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-03-18 16:56:43 PDT
Created
attachment 227132
[details]
Patch
Sam Weinig
Comment 2
2014-03-18 19:36:35 PDT
Comment on
attachment 227132
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=227132&action=review
> Source/WebCore/platform/KeyedCoding.h:79 > + // FIXME: This doesn't distinguish between a missing object dictionary or a value of a different type.
This took me a bit to parse. I would add a little bit more information about how its beginObject() doesn't distinguish and why return true.
Anders Carlsson
Comment 3
2014-03-19 10:37:02 PDT
Committed
r165900
: <
http://trac.webkit.org/changeset/165900
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug