Bug 130433 - Add new functionality that will be required by the history item decoding
Summary: Add new functionality that will be required by the history item decoding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 16:55 PDT by Anders Carlsson
Modified: 2014-03-19 10:37 PDT (History)
0 users

See Also:

Attachments
Patch (5.14 KB, patch)
2014-03-18 16:56 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-03-18 16:55:08 PDT 
Add new functionality that will be required by the history item decoding
Comment 1 Anders Carlsson 2014-03-18 16:56:43 PDT 
Created attachment 227132 [details]
Patch
Comment 2 Sam Weinig 2014-03-18 19:36:35 PDT 
Comment on attachment 227132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227132&action=review

> Source/WebCore/platform/KeyedCoding.h:79
> +        // FIXME: This doesn't distinguish between a missing object dictionary or a value of a different type.

This took me a bit to parse.  I would add a little bit more information about how its beginObject() doesn't distinguish and why return true.
Comment 3 Anders Carlsson 2014-03-19 10:37:02 PDT 
Committed r165900: <http://trac.webkit.org/changeset/165900>