Bug 130430 - Subpixel rendering: RenderBox is positioned off by one when non-compositing transform is present.
Summary: Subpixel rendering: RenderBox is positioned off by one when non-compositing t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on: 130153
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-18 15:36 PDT by zalan
Modified: 2014-03-21 06:56 PDT (History)
15 users (show)

See Also:


Attachments
test case (684 bytes, text/html)
2014-03-18 15:37 PDT, zalan
no flags Details
Patch (8.58 KB, patch)
2014-03-19 22:04 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (10.12 KB, patch)
2014-03-20 08:05 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (20.11 KB, patch)
2014-03-20 20:26 PDT, zalan
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-03-18 15:36:45 PDT
and produces cruft.
Comment 1 zalan 2014-03-18 15:37:19 PDT
Created attachment 227121 [details]
test case
Comment 2 zalan 2014-03-19 22:04:59 PDT
Created attachment 227255 [details]
Patch
Comment 3 zalan 2014-03-19 22:07:49 PDT
This patch depends on bug 130153, won't compile.
Comment 4 zalan 2014-03-20 08:05:20 PDT
Created attachment 227289 [details]
Patch
Comment 5 zalan 2014-03-20 08:06:39 PDT
Comment on attachment 227289 [details]
Patch

EWS testing
Comment 6 zalan 2014-03-20 10:08:09 PDT
Comment on attachment 227289 [details]
Patch

All green!
Comment 7 Timothy Hatcher 2014-03-20 10:17:52 PDT
(In reply to comment #6)
> (From update of attachment 227289 [details])
> All green!

Super green!
Comment 8 zalan 2014-03-20 20:26:03 PDT
Created attachment 227372 [details]
Patch
Comment 9 Simon Fraser (smfr) 2014-03-20 21:09:40 PDT
Comment on attachment 227372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227372&action=review

> Source/WebCore/ChangeLog:29
> +        When the translate moves the graphics context's origo over the renderer's top-left position,

origo->origin
Comment 10 zalan 2014-03-21 06:56:06 PDT
Committed r166060: <http://trac.webkit.org/changeset/166060>