RESOLVED FIXED 130414
WebPageCreationParameters colorSpace should be MAC not COCOA 
https://bugs.webkit.org/show_bug.cgi?id=130414
Summary WebPageCreationParameters colorSpace should be MAC not COCOA
Joseph Pecoraro
Reported 2014-03-18 12:55:31 PDT
WebPageCreationParameters colorSpace is only used by PLATFORM(MAC), but it is defined as PLATFORM(COCOA). The only use I see is in !PLATFORM(IOS) code: WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 87: setColorSpace(parameters.colorSpace);
Attachments
[PATCH] Proposed Fix (2.22 KB, patch)
2014-03-18 12:57 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-03-18 12:57:54 PDT
Created attachment 227093 [details] [PATCH] Proposed Fix
mitz
Comment 2 2014-03-18 13:02:19 PDT
Comment on attachment 227093 [details] [PATCH] Proposed Fix rs=me
Joseph Pecoraro
Comment 3 2014-03-18 13:05:35 PDT
Comment on attachment 227093 [details] [PATCH] Proposed Fix I suspect this will collide with another patch changing a line nearby. cq may not work, but lets try anyways.
WebKit Commit Bot
Comment 4 2014-03-18 13:19:08 PDT
Comment on attachment 227093 [details] [PATCH] Proposed Fix Clearing flags on attachment: 227093 Committed r165839: <http://trac.webkit.org/changeset/165839>
WebKit Commit Bot
Comment 5 2014-03-18 13:19:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.