Bug 130414 - WebPageCreationParameters colorSpace should be MAC not COCOA
Summary: WebPageCreationParameters colorSpace should be MAC not COCOA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 12:55 PDT by Joseph Pecoraro
Modified: 2014-03-18 13:19 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.22 KB, patch)
2014-03-18 12:57 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-18 12:55:31 PDT 
WebPageCreationParameters colorSpace is only used by PLATFORM(MAC), but it is defined as PLATFORM(COCOA).

The only use I see is in !PLATFORM(IOS) code:

  WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
  87:    setColorSpace(parameters.colorSpace);
Comment 1 Joseph Pecoraro 2014-03-18 12:57:54 PDT 
Created attachment 227093 [details]
[PATCH] Proposed Fix
Comment 2 mitz 2014-03-18 13:02:19 PDT 
Comment on attachment 227093 [details]
[PATCH] Proposed Fix

rs=me
Comment 3 Joseph Pecoraro 2014-03-18 13:05:35 PDT 
Comment on attachment 227093 [details]
[PATCH] Proposed Fix

I suspect this will collide with another patch changing a line nearby. cq may not work, but lets try anyways.
Comment 4 WebKit Commit Bot 2014-03-18 13:19:08 PDT 
Comment on attachment 227093 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 227093

Committed r165839: <http://trac.webkit.org/changeset/165839>
Comment 5 WebKit Commit Bot 2014-03-18 13:19:12 PDT 
All reviewed patches have been landed.  Closing bug.