Bug 130412 - Web Inspector: Make update-InspectorBackendCommands.rb only update legacy protocol versions
Summary: Web Inspector: Make update-InspectorBackendCommands.rb only update legacy pro...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2014-03-18 12:05 PDT by Joseph Pecoraro
Modified: 2014-03-18 13:07 PDT (History)
6 users (show)

See Also:

[PATCH] Proposed Fix (5.23 KB, patch)
2014-03-18 12:07 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-18 12:05:10 PDT
Now that tip of tree files are generated at build time depending on ENABLE flags, this script does not need to update ToT backend commands. It may still be useful to update the legacy protocol versions (iOS6, and iOS7) if the CodeGenerator ever changes to produce slightly different output.
Comment 1 Joseph Pecoraro 2014-03-18 12:07:06 PDT
Created attachment 227086 [details]
[PATCH] Proposed Fix

shell> ./Scripts/update-LegacyInspectorBackendCommands.rb 
Inspector-iOS-6.0.json -> UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js
Inspector-iOS-7.0.json -> UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js
Comment 2 WebKit Commit Bot 2014-03-18 13:07:54 PDT
Comment on attachment 227086 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 227086

Committed r165838: <http://trac.webkit.org/changeset/165838>
Comment 3 WebKit Commit Bot 2014-03-18 13:07:59 PDT
All reviewed patches have been landed.  Closing bug.