Bug 130406 - Fix cue rendering test and include support for left/right alignment.
Summary: Fix cue rendering test and include support for left/right alignment.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL: https://codereview.chromium.org/25155003
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 10:44 PDT by Brent Fulgham
Modified: 2014-03-19 12:00 PDT (History)
9 users (show)

See Also:


Attachments
Patch (22.93 KB, patch)
2014-03-19 11:29 PDT, Brent Fulgham
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-03-18 10:44:29 PDT
Merge Blink change https://codereview.chromium.org/25155003.
Comment 1 Brent Fulgham 2014-03-19 11:29:36 PDT
Created attachment 227204 [details]
Patch
Comment 2 Eric Carlson 2014-03-19 11:34:30 PDT
Comment on attachment 227204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227204&action=review

> Source/WebCore/html/track/VTTCue.cpp:618
> +    } else {
> +        ASSERT_NOT_REACHED();
>      }

Nit: I don't think the braces are necessary.
Comment 3 Brent Fulgham 2014-03-19 11:37:12 PDT
(In reply to comment #2)
> (From update of attachment 227204 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227204&action=review
> 
> > Source/WebCore/html/track/VTTCue.cpp:618
> > +    } else {
> > +        ASSERT_NOT_REACHED();
> >      }
> 
> Nit: I don't think the braces are necessary.

OK. I'll remove!
Comment 4 Brent Fulgham 2014-03-19 12:00:55 PDT
Committed r165905: <http://trac.webkit.org/changeset/165905>