Bug 130403 - Visual Studio 2013 complains about implicit casts of uint8_t enums to bool
Summary: Visual Studio 2013 complains about implicit casts of uint8_t enums to bool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 10:07 PDT by BJ Burg
Modified: 2016-03-22 13:36 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-03-18 10:07:31 PDT 
Not sure if this is undefined behavior or if its an MSVC bug, but it sure does spam the build output.


At JSCell.h:156:
    void setRemembered(bool remembered)
    {
        ASSERT(m_gcData == remembered ? Marked : MarkedAndRemembered);

given the following definition

    enum GCData : uint8_t {
        Marked = 0,
        NotMarked = 1,
        MarkedAndRemembered = 2,
    };
Comment 1 Brent Fulgham 2016-03-22 13:36:02 PDT 
I don't see this anymore now that we are on VS2015.