WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130385
[iOS][WebKit2] Provide generic software-snapshotting API
https://bugs.webkit.org/show_bug.cgi?id=130385
Summary
[iOS][WebKit2] Provide generic software-snapshotting API
Tim Horton
Reported
2014-03-17 23:17:08 PDT
We should provide a single method on WKWebView that does an async software paint of a given rect in view space into an image of a given size. <
rdar://problem/16005957
>
Attachments
patch
(11.60 KB, patch)
2014-03-18 11:15 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(14.81 KB, patch)
2014-03-18 15:04 PDT
,
Tim Horton
sam
: review+
Details
Formatted Diff
Diff
ignore this patch
(4.08 KB, patch)
2014-03-18 20:45 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2014-03-18 11:15:38 PDT
Created
attachment 227078
[details]
patch
Ian Henderson
Comment 2
2014-03-18 11:27:18 PDT
Comment on
attachment 227078
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=227078&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:361 > + if (!imageHandle.isNull()) { > + RefPtr<WebKit::ShareableBitmap> bitmap = WebKit::ShareableBitmap::create(imageHandle, WebKit::SharedMemory::ReadOnly); > + > + if (bitmap) { > + RetainPtr<CGImageRef> cgImage; > + cgImage = bitmap->makeCGImage(); > + copiedCompletionHandler(cgImage.get()); > + } > + } > + > + [copiedCompletionHandler release];
Clients should be able to rely on the completion handler being called, even if something went wrong. Could we call the completion handler with a nil argument in this case instead of not calling it at all?
Tim Horton
Comment 3
2014-03-18 15:04:38 PDT
Created
attachment 227116
[details]
patch
WebKit Commit Bot
Comment 4
2014-03-18 15:05:53 PDT
Attachment 227116
[details]
did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:425: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:425: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 5
2014-03-18 20:45:56 PDT
Created
attachment 227151
[details]
ignore this patch
Sam Weinig
Comment 6
2014-03-18 22:08:39 PDT
Comment on
attachment 227151
[details]
ignore this patch This might build, but it is attached to the wrong bug.
Tim Horton
Comment 7
2014-03-18 22:29:24 PDT
(In reply to
comment #6
)
> (From update of
attachment 227151
[details]
) > This might build, but it is attached to the wrong bug.
Re r?'d the relevant patch.
Tim Horton
Comment 8
2014-03-18 23:56:12 PDT
http://trac.webkit.org/changeset/165872
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug