Bug 130382 - [iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard rect for computing the general unobscuredRect, only use it for centering
Summary: [iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard rect for com...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 20:18 PDT by Benjamin Poulain
Modified: 2014-03-19 14:55 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2014-03-17 20:20 PDT, Benjamin Poulain 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-03-17 20:18:52 PDT 
[iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard rect for computing the general unobscuredRect, only use it for centering
Comment 1 Benjamin Poulain 2014-03-17 20:20:28 PDT 
Created attachment 227003 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-03-17 22:28:39 PDT 
Comment on attachment 227003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227003&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:632
> +- (CGRect)_unobscuredContentRectIncludingKeyboard

This name is confusing. Does the unobscuring include or exclude the keyboard?
Comment 3 Benjamin Poulain 2014-03-19 14:55:44 PDT 
Committed r165924: <http://trac.webkit.org/changeset/165924>