Bug 130380 - V8 regexp spends most time in operationGetById
Summary: V8 regexp spends most time in operationGetById
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 18:31 PDT by Michael Saboff
Modified: 2014-03-17 20:46 PDT (History)
0 users

See Also:

Attachments
Patch (7.61 KB, patch)
2014-03-17 19:04 PDT, Michael Saboff 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-03-17 18:31:21 PDT 
Profiling shows that operationGetById is the hottest function when running V8 regexp
Comment 1 Michael Saboff 2014-03-17 19:04:26 PDT 
Created attachment 226999 [details]
Patch

When V8 regexp is run from the command line, this patch nets a 2% performance improvement.

Using the JS performance test script, this patch didn't noticeably improve performance.  This is likely due to longer running code being optimized by the DFG.
Comment 2 Michael Saboff 2014-03-17 20:46:50 PDT 
Committed r165797: <http://trac.webkit.org/changeset/165797>