Bug 130377 - Web Inspector: sourceMapResourceLoaded expects statusCode parameter
Summary: Web Inspector: sourceMapResourceLoaded expects statusCode parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-17 18:05 PDT by Joseph Pecoraro
Modified: 2014-03-18 07:34 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.46 KB, patch)
2014-03-17 18:07 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-17 18:05:11 PDT 
Harmless, but explicitly provide a status code to our manual call of sourceMapResourceLoaded.
Comment 1 Joseph Pecoraro 2014-03-17 18:07:46 PDT 
Created attachment 226992 [details]
[PATCH] Proposed Fix

Harmless, but nice cleanup.

Context:
...
82:        function sourceMapResourceLoaded(error, body, mimeType, statusCode)
83-        {
84-            const base64encoded = false;
85-
86-            if (error || statusCode >= 400) {
87-                this.markAsFailed();
...

js> undefined >= 400
false
Comment 2 WebKit Commit Bot 2014-03-18 07:34:08 PDT 
Comment on attachment 226992 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 226992

Committed r165811: <http://trac.webkit.org/changeset/165811>
Comment 3 WebKit Commit Bot 2014-03-18 07:34:10 PDT 
All reviewed patches have been landed.  Closing bug.