Add transparent window support back into MiniBrowser
Created attachment 226968 [details] Patch
Attachment 226968 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 226968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84 > +@property (nonatomic, setter=_setDrawsTransparentBackground:)BOOL _drawsTransparentBackground; spaces around =
Comment on attachment 226968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:257 > + [[self window] setOpaque:!isTransparent]; > + [[self window] setHasShadow:!isTransparent]; I think you should use dot notation here.
Comment on attachment 226968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84 >> +@property (nonatomic, setter=_setDrawsTransparentBackground:)BOOL _drawsTransparentBackground; > > spaces around = and after the )
Comment on attachment 226968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:34 > +#import <WebKit2/WKWebViewPrivate.h> > #import <WebKit2/WKNavigationDelegate.h> This doesn't look sorted right.
I think this landed in http://trac.webkit.org/changeset/165775 and http://trac.webkit.org/changeset/165776