Bug 130359 - [Mac] Standardize on start/length in text input IPC methods
Summary: [Mac] Standardize on start/length in text input IPC methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 14:05 PDT by Alexey Proskuryakov
Modified: 2014-03-17 14:32 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (32.91 KB, patch)
2014-03-17 14:09 PDT, Alexey Proskuryakov 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-17 14:05:16 PDT 
Some IPC methods use start/length, and others use start/end. This is confusing.

Most implementation methods just compute length from start/end as the first thing they do, so it's better to standardize on this I think.
Comment 1 Alexey Proskuryakov 2014-03-17 14:09:18 PDT 
Created attachment 226962 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2014-03-17 14:32:12 PDT 
Committed <http://trac.webkit.org/r165759>.