Bug 130358 - Make Remote Control commands testable
Summary: Make Remote Control commands testable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 14:02 PDT by Eric Carlson
Modified: 2014-03-19 14:09 PDT (History)
10 users (show)

See Also:

Attachments
Proposed patch (21.97 KB, patch)
2014-03-18 07:50 PDT, Eric Carlson 		jer.noble: review+
Details | Formatted Diff | Diff
Rebased patch for landing (22.04 KB, patch)
2014-03-18 10:14 PDT, Eric Carlson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (605.86 KB, application/zip)
2014-03-18 10:49 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (541.29 KB, application/zip)
2014-03-18 13:45 PDT, Build Bot 		no flags Details
Updated patch (26.50 KB, patch)
2014-03-19 12:06 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-03-17 14:02:36 PDT 
Make it possible to post Remote Control commands via Internals.
Comment 1 Eric Carlson 2014-03-18 07:50:48 PDT 
Created attachment 227050 [details]
Proposed patch
Comment 2 Jer Noble 2014-03-18 10:12:26 PDT 
Comment on attachment 227050 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227050&action=review

r=me, with nit. (and a rebaseline needed)

> Source/WebCore/platform/audio/MediaSessionManager.cpp:207
> +    if (m_sessions.size() < 2)
> +        return;

This code will skip the ASSERT below if m_sessions is empty.  Should this be:?

ASSERT(m_sessions.size());
if (m_sessions.size() == 1)
    return;
Comment 3 Eric Carlson 2014-03-18 10:14:11 PDT 
Created attachment 227066 [details]
Rebased patch for landing
Comment 4 WebKit Commit Bot 2014-03-18 10:16:53 PDT 
Attachment 227066 [details] did not pass style-queue:


ERROR: Source/WebCore/testing/Internals.h:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2014-03-18 10:49:35 PDT 
Comment on attachment 227066 [details]
Rebased patch for landing

Attachment 227066 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6696129597014016

New failing tests:
media/video-background-playback.html
Comment 6 Build Bot 2014-03-18 10:49:38 PDT 
Created attachment 227075 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-03-18 13:45:43 PDT 
Created attachment 227104 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Eric Carlson 2014-03-19 12:06:34 PDT 
Created attachment 227207 [details]
Updated patch
Comment 9 Jer Noble 2014-03-19 13:34:59 PDT 
Comment on attachment 227207 [details]
Updated patch

Re-r=me.
Comment 10 WebKit Commit Bot 2014-03-19 14:08:55 PDT 
Comment on attachment 227207 [details]
Updated patch

Clearing flags on attachment: 227207

Committed r165916: <http://trac.webkit.org/changeset/165916>
Comment 11 WebKit Commit Bot 2014-03-19 14:09:01 PDT 
All reviewed patches have been landed.  Closing bug.