Bug 130358 – Make Remote Control commands testable

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Make it possible to post Remote Control commands via Internals.

[Eric Carlson]

Created attachment 227050 [details]
Proposed patch

[Jer Noble]

Comment on attachment 227050 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227050&action=review

r=me, with nit. (and a rebaseline needed)

> Source/WebCore/platform/audio/MediaSessionManager.cpp:207
> +    if (m_sessions.size() < 2)
> +        return;

This code will skip the ASSERT below if m_sessions is empty.  Should this be:?

ASSERT(m_sessions.size());
if (m_sessions.size() == 1)
    return;

[Eric Carlson]

Created attachment 227066 [details]
Rebased patch for landing

[WebKit Commit Bot]

Attachment 227066 [details] did not pass style-queue:


ERROR: Source/WebCore/testing/Internals.h:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 227066 [details]
Rebased patch for landing

Attachment 227066 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6696129597014016

New failing tests:
media/video-background-playback.html

[Build Bot]

Created attachment 227075 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Created attachment 227104 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Eric Carlson]

Created attachment 227207 [details]
Updated patch

[Jer Noble]

Comment on attachment 227207 [details]
Updated patch

Re-r=me.

[WebKit Commit Bot]

Comment on attachment 227207 [details]
Updated patch

Clearing flags on attachment: 227207

Committed r165916: <http://trac.webkit.org/changeset/165916>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.