Bug 130355 - Add SPI for getting bundle parameters from the injected bundle
Summary: Add SPI for getting bundle parameters from the injected bundle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 13:07 PDT by Anders Carlsson
Modified: 2014-03-17 13:38 PDT (History)
0 users

See Also:

Attachments
Patch (18.98 KB, patch)
2014-03-17 13:09 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-03-17 13:07:43 PDT 
Add SPI for getting bundle parameters from the injected bundle
Comment 1 Anders Carlsson 2014-03-17 13:09:03 PDT 
Created attachment 226947 [details]
Patch
Comment 2 mitz 2014-03-17 13:28:21 PDT 
Comment on attachment 226947 [details]
Patch

>+    _parameters = adoptNS([[NSMutableDictionary alloc] initWithDictionary:dictionary]);

Is this better than -mutableCopy?

> 
> #if USE(FOUNDATION)
> OBJC_CLASS NSBundle;
>+OBJC_CLASS NSMutableDictionary;
>+OBJC_CLASS WKWebProcessBundleParameters;

Shouldn’t this be only #if WK_API_ENABLED ?

> 
>+#if PLATFORM(COCOA)
>+    WKWebProcessBundleParameters *bundleParameters();
>+#endif

Ditto.


>+
>+#if PLATFORM(COCOA)
>+    RetainPtr<WKWebProcessBundleParameters> m_bundleParameters;
>+#endif

Ditto.
Comment 3 Anders Carlsson 2014-03-17 13:38:53 PDT 
Committed r165755: <http://trac.webkit.org/changeset/165755>