WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130355
Add SPI for getting bundle parameters from the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=130355
Summary
Add SPI for getting bundle parameters from the injected bundle
Anders Carlsson
Reported
2014-03-17 13:07:43 PDT
Add SPI for getting bundle parameters from the injected bundle
Attachments
Patch
(18.98 KB, patch)
2014-03-17 13:09 PDT
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-03-17 13:09:03 PDT
Created
attachment 226947
[details]
Patch
mitz
Comment 2
2014-03-17 13:28:21 PDT
Comment on
attachment 226947
[details]
Patch
>+ _parameters = adoptNS([[NSMutableDictionary alloc] initWithDictionary:dictionary]);
Is this better than -mutableCopy?
> > #if USE(FOUNDATION) > OBJC_CLASS NSBundle; >+OBJC_CLASS NSMutableDictionary; >+OBJC_CLASS WKWebProcessBundleParameters;
Shouldn’t this be only #if WK_API_ENABLED ?
> >+#if PLATFORM(COCOA) >+ WKWebProcessBundleParameters *bundleParameters(); >+#endif
Ditto.
>+ >+#if PLATFORM(COCOA) >+ RetainPtr<WKWebProcessBundleParameters> m_bundleParameters; >+#endif
Ditto.
Anders Carlsson
Comment 3
2014-03-17 13:38:53 PDT
Committed
r165755
: <
http://trac.webkit.org/changeset/165755
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug