Bug 130336 - [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
Summary: [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 07:41 PDT by Rob Płóciennik
Modified: 2014-03-18 05:51 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (2.78 KB, patch)
2014-03-17 07:43 PDT, Rob Płóciennik
no flags Details | Formatted Diff | Diff
Proposed patch (2.86 KB, patch)
2014-03-18 04:34 PDT, Rob Płóciennik
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Płóciennik 2014-03-17 07:41:53 PDT
fontconfig-2.8.0 is not compliant with C++11 which leads to a build break on gcc 4.8.x.
Comment 1 Rob Płóciennik 2014-03-17 07:43:40 PDT
Created attachment 226915 [details]
Proposed patch
Comment 2 Csaba Osztrogonác 2014-03-17 08:56:20 PDT
How come it didn't cause build failure previously?
We have used fontconfig 2.8 long time ago 
and there are many developers use GCC 4.8.
Comment 3 Rob Płóciennik 2014-03-17 09:04:54 PDT
(In reply to comment #2)
> How come it didn't cause build failure previously?

Perhaps this only started to occur when compiling with language standard explicitly set to C++11?

The corresponding patch for GTK was just merged on Jan 21 2014 although this very issue has been detected/patched in Fontconfig at least 2 years ago.
Comment 4 Gyuyoung Kim 2014-03-18 02:44:02 PDT
Comment on attachment 226915 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226915&action=review

As ossy said, could you show the build error log when compiling WebKit EFL with C++11 ?

> Tools/ChangeLog:8
> +        fontconfig-2.8.0 is not compliant with C++11 which leads to a build break

This description looks redundant because bug title is almost same with description.
Comment 5 Rob Płóciennik 2014-03-18 04:18:45 PDT
(In reply to comment #4)

> As ossy said, could you show the build error log when compiling WebKit EFL with C++11 ?

Oh, right. I'm encountering the same issues as presented here:
http://lists.freedesktop.org/archives/fontconfig/2012-April/003927.html

Not to mention that the person that replies to that message is the same that provided the patch included in this patch and the original GTK one (9aa823564), referenced here.

> This description looks redundant because bug title is almost same with description.

True, updating the ChangeLog accordingly as we speak...
Comment 6 Rob Płóciennik 2014-03-18 04:34:57 PDT
Created attachment 227033 [details]
Proposed patch
Comment 7 Gyuyoung Kim 2014-03-18 05:21:41 PDT
Comment on attachment 227033 [details]
Proposed patch

As mentioned in bug 127283, I believe EFL port doesn't want to slip C++11 into WebKit code as well. LGTM.
Comment 8 WebKit Commit Bot 2014-03-18 05:51:47 PDT
Comment on attachment 227033 [details]
Proposed patch

Clearing flags on attachment: 227033

Committed r165808: <http://trac.webkit.org/changeset/165808>
Comment 9 WebKit Commit Bot 2014-03-18 05:51:52 PDT
All reviewed patches have been landed.  Closing bug.