Bug 130331 - [CSS Blending] layerTreeAsText should dump layer's blendMode property
Summary: [CSS Blending] layerTreeAsText should dump layer's blendMode property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 95614 130337
  Show dependency treegraph
 
Reported: 2014-03-17 06:35 PDT by Ion Rosca
Modified: 2014-03-18 01:52 PDT (History)
6 users (show)

See Also:


Attachments
path v1 (4.22 KB, patch)
2014-03-17 07:09 PDT, Ion Rosca
no flags Details | Formatted Diff | Diff
path v2 (4.30 KB, patch)
2014-03-17 07:24 PDT, Ion Rosca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ion Rosca 2014-03-17 06:35:21 PDT
Currently layerTreeAsText doesn't provide any info on how blend mode is propagated to GraphicsLayers. There are some cases we should check if blend mode is correctly set, for example, when the blending layer has an ancestor clipping layer.
Comment 1 Ion Rosca 2014-03-17 07:09:42 PDT
Created attachment 226910 [details]
path v1
Comment 2 Mihai Tica 2014-03-17 07:22:58 PDT
Don't forget to proper guard the blending changes with
#ifdef ENABLE(CSS_COMPOSITING)
// blending code
#endif
Comment 3 Ion Rosca 2014-03-17 07:24:07 PDT
Created attachment 226911 [details]
path v2
Comment 4 WebKit Commit Bot 2014-03-18 01:52:26 PDT
Comment on attachment 226911 [details]
path v2

Clearing flags on attachment: 226911

Committed r165804: <http://trac.webkit.org/changeset/165804>
Comment 5 WebKit Commit Bot 2014-03-18 01:52:30 PDT
All reviewed patches have been landed.  Closing bug.