Bug 130315 – CSSValueList should assert that no null values are added to it.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Andreas Kling]

CSSValueList should assert that no null values are added to it.

[Andreas Kling]

Created attachment 226865 [details]
Patch

[WebKit Commit Bot]

Attachment 226865 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSValueList.h:57:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/css/CSSValueList.h:58:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 226865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226865&action=review

Bot says:

Regressions: Unexpected crashes (1)
  mathml/wbr-in-mroot-crash.html [ Crash ]

r=me if you look into that

> Source/WebCore/css/CSSValueList.h:58
> +    void append(PassRefPtr<CSSValue> value);
> +    void prepend(PassRefPtr<CSSValue> value);

Like the style bot says, you should remove the argument names here.

[Andreas Kling]

Committed r165717: <http://trac.webkit.org/changeset/165717>