Bug 130313 - Use RunLoop objects through references instead of pointers
Summary: Use RunLoop objects through references instead of pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-16 14:08 PDT by Zan Dobersek
Modified: 2014-03-17 11:48 PDT (History)
8 users (show)

See Also:


Attachments
WIP (40.10 KB, patch)
2014-03-16 14:10 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (39.48 KB, patch)
2014-03-16 15:16 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (40.53 KB, patch)
2014-03-17 07:40 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-03-16 14:08:58 PDT
Use RunLoop objects through references instead of pointers
Comment 1 Zan Dobersek 2014-03-16 14:10:05 PDT
Created attachment 226859 [details]
WIP

Running through EWS.
Comment 2 Early Warning System Bot 2014-03-16 14:13:01 PDT
Attachment 226859 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-03-16 14:28:57 PDT
/Volumes/Data/EWS/WebKit/Source/WTF/wtf/cf/RunLoopCF.cpp:68:14: error: member reference type 'WTF::RunLoop' is not a pointer
    current()->m_nestingLevel++;
    ~~~~~~~~~^
/Volumes/Data/EWS/WebKit/Source/WTF/wtf/cf/RunLoopCF.cpp:75:14: error: member reference type 'WTF::RunLoop' is not a pointer
    current()->m_nestingLevel--;
    ~~~~~~~~~^
Comment 4 Zan Dobersek 2014-03-16 15:16:34 PDT
Created attachment 226863 [details]
Patch
Comment 5 Andreas Kling 2014-03-16 15:57:58 PDT
Comment on attachment 226863 [details]
Patch

/Volumes/Data/EWS/WebKit/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:447:28: error: member reference type 'WTF::RunLoop' is not a pointer
            m_clientRunLoop->dispatch(bind(&Connection::dispatchDidReceiveInvalidMessage, this, decoder->messageReceiverName().toString(), decoder->messageName().toString()));
            ~~~~~~~~~~~~~~~^

r=me once you get it to build :)
Comment 6 Zan Dobersek 2014-03-17 07:40:58 PDT
Created attachment 226914 [details]
Patch for landing

Landing candidate if the EWSs process it successfully.
Comment 7 Zan Dobersek 2014-03-17 11:48:06 PDT
Comment on attachment 226914 [details]
Patch for landing

Clearing flags on attachment: 226914

Committed r165746: <http://trac.webkit.org/changeset/165746>
Comment 8 Zan Dobersek 2014-03-17 11:48:36 PDT
All reviewed patches have been landed.  Closing bug.