RESOLVED FIXED 130313
Use RunLoop objects through references instead of pointers 
https://bugs.webkit.org/show_bug.cgi?id=130313
Summary Use RunLoop objects through references instead of pointers
Zan Dobersek
Reported 2014-03-16 14:08:58 PDT
Use RunLoop objects through references instead of pointers
Attachments
WIP (40.10 KB, patch)
2014-03-16 14:10 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (39.48 KB, patch)
2014-03-16 15:16 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (40.53 KB, patch)
2014-03-17 07:40 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-03-16 14:10:05 PDT
Created attachment 226859 [details] WIP Running through EWS.
Early Warning System Bot
Comment 2 2014-03-16 14:13:01 PDT
Attachment 226859 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2014-03-16 14:28:57 PDT
/Volumes/Data/EWS/WebKit/Source/WTF/wtf/cf/RunLoopCF.cpp:68:14: error: member reference type 'WTF::RunLoop' is not a pointer current()->m_nestingLevel++; ~~~~~~~~~^ /Volumes/Data/EWS/WebKit/Source/WTF/wtf/cf/RunLoopCF.cpp:75:14: error: member reference type 'WTF::RunLoop' is not a pointer current()->m_nestingLevel--; ~~~~~~~~~^
Zan Dobersek
Comment 4 2014-03-16 15:16:34 PDT
Created attachment 226863 [details] Patch
Andreas Kling
Comment 5 2014-03-16 15:57:58 PDT
Comment on attachment 226863 [details] Patch /Volumes/Data/EWS/WebKit/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:447:28: error: member reference type 'WTF::RunLoop' is not a pointer m_clientRunLoop->dispatch(bind(&Connection::dispatchDidReceiveInvalidMessage, this, decoder->messageReceiverName().toString(), decoder->messageName().toString())); ~~~~~~~~~~~~~~~^ r=me once you get it to build :)
Zan Dobersek
Comment 6 2014-03-17 07:40:58 PDT
Created attachment 226914 [details] Patch for landing Landing candidate if the EWSs process it successfully.
Zan Dobersek
Comment 7 2014-03-17 11:48:06 PDT
Comment on attachment 226914 [details] Patch for landing Clearing flags on attachment: 226914 Committed r165746: <http://trac.webkit.org/changeset/165746>
Zan Dobersek
Comment 8 2014-03-17 11:48:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.