Bug 130312 - Use an anonymous union of std::unique_ptr members in SVGAnimatedType
Summary: Use an anonymous union of std::unique_ptr members in SVGAnimatedType
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-16 13:49 PDT by Zan Dobersek
Modified: 2014-03-16 19:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (22.14 KB, patch)
2014-03-16 14:49 PDT, Zan Dobersek 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-03-16 13:49:02 PDT 
Use an anonymous union of std::unique_ptr members in SVGAnimatedType
Comment 1 Zan Dobersek 2014-03-16 14:49:57 PDT 
Created attachment 226861 [details]
Patch
Comment 2 Darin Adler 2014-03-16 19:23:59 PDT 
Comment on attachment 226861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226861&action=review

> Source/WebCore/ChangeLog:10
> +        Make the union in SVGAnimatedType anonymous. The members of the union are now
> +        std::unique_ptr objects instead of raw pointers, enabling simply moving the
> +        passed-in std::unique_ptr objects in create*() methods.

Great idea, but looks like the Windows compiler does not support this advanced C++ feature yet.

Can’t do this unless we solve this problem on Windows.