Bug 130310 - Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
Summary: Explicitly include cstdio header for debug builds in InlineTextBox, RenderLay...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-16 13:19 PDT by Zan Dobersek
Modified: 2014-03-17 10:16 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2014-03-16 13:26 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-03-16 13:19:15 PDT
Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
Comment 1 Zan Dobersek 2014-03-16 13:26:24 PDT
Created attachment 226857 [details]
Patch
Comment 2 Darin Adler 2014-03-16 14:15:19 PDT
Comment on attachment 226857 [details]
Patch

I don’t think these includes should be inside #if statements. I also think it’s a little strange that we include <cstdio> rather than <stdio.h> since we call the function fprintf, not std::fprintf.
Comment 3 Zan Dobersek 2014-03-17 07:59:35 PDT
Comment on attachment 226857 [details]
Patch

Clearing flags on attachment: 226857

Committed r165732: <http://trac.webkit.org/changeset/165732>
Comment 4 Zan Dobersek 2014-03-17 07:59:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Zan Dobersek 2014-03-17 09:33:37 PDT
(In reply to comment #2)
> (From update of attachment 226857 [details])
> I don’t think these includes should be inside #if statements. I also think it’s a little strange that we include <cstdio> rather than <stdio.h> since we call the function fprintf, not std::fprintf.

Forgot to address this before landing, but did address it in r165736.
http://trac.webkit.org/changeset/165736
Comment 6 Simon Fraser (smfr) 2014-03-17 10:16:19 PDT
Maybe we should change those printfs to use WTFLogAlways.