WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130310
Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
https://bugs.webkit.org/show_bug.cgi?id=130310
Summary
Explicitly include cstdio header for debug builds in InlineTextBox, RenderLay...
Zan Dobersek
Reported
2014-03-16 13:19:15 PDT
Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
Attachments
Patch
(2.30 KB, patch)
2014-03-16 13:26 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2014-03-16 13:26:24 PDT
Created
attachment 226857
[details]
Patch
Darin Adler
Comment 2
2014-03-16 14:15:19 PDT
Comment on
attachment 226857
[details]
Patch I don’t think these includes should be inside #if statements. I also think it’s a little strange that we include <cstdio> rather than <stdio.h> since we call the function fprintf, not std::fprintf.
Zan Dobersek
Comment 3
2014-03-17 07:59:35 PDT
Comment on
attachment 226857
[details]
Patch Clearing flags on attachment: 226857 Committed
r165732
: <
http://trac.webkit.org/changeset/165732
>
Zan Dobersek
Comment 4
2014-03-17 07:59:43 PDT
All reviewed patches have been landed. Closing bug.
Zan Dobersek
Comment 5
2014-03-17 09:33:37 PDT
(In reply to
comment #2
)
> (From update of
attachment 226857
[details]
) > I don’t think these includes should be inside #if statements. I also think it’s a little strange that we include <cstdio> rather than <stdio.h> since we call the function fprintf, not std::fprintf.
Forgot to address this before landing, but did address it in
r165736
.
http://trac.webkit.org/changeset/165736
Simon Fraser (smfr)
Comment 6
2014-03-17 10:16:19 PDT
Maybe we should change those printfs to use WTFLogAlways.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug