Bug 130294 - Move BorderEdge class to its own file.
Summary: Move BorderEdge class to its own file.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-15 10:22 PDT by zalan
Modified: 2014-03-15 21:57 PDT (History)
10 users (show)

See Also:


Attachments
Patch (42.60 KB, patch)
2014-03-15 13:04 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (43.07 KB, patch)
2014-03-15 19:50 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-03-15 10:22:25 PDT
This is in preparation to have better encapsulation for border box decoration painting.
Comment 1 zalan 2014-03-15 13:04:45 PDT
Created attachment 226826 [details]
Patch
Comment 2 Sam Weinig 2014-03-15 18:33:15 PDT
Comment on attachment 226826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review

> Source/WebCore/rendering/BorderEdge.h:49
> +    BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio);

I wonder how much sense it makes to pass Color by reference (rather than by value) these days.
Comment 3 zalan 2014-03-15 18:51:35 PDT
(In reply to comment #2)
> (From update of attachment 226826 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review
> 
> > Source/WebCore/rendering/BorderEdge.h:49
> > +    BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio);
> 
> I wonder how much sense it makes to pass Color by reference (rather than by value) these days.

Good point. I'll make that change.
Comment 4 zalan 2014-03-15 19:50:08 PDT
Created attachment 226830 [details]
Patch
Comment 5 zalan 2014-03-15 19:50:25 PDT
Comment on attachment 226830 [details]
Patch

EWS testing.
Comment 6 WebKit Commit Bot 2014-03-15 21:57:31 PDT
Comment on attachment 226830 [details]
Patch

Clearing flags on attachment: 226830

Committed r165689: <http://trac.webkit.org/changeset/165689>
Comment 7 WebKit Commit Bot 2014-03-15 21:57:36 PDT
All reviewed patches have been landed.  Closing bug.