This is in preparation to have better encapsulation for border box decoration painting.
Created attachment 226826 [details] Patch
Comment on attachment 226826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review > Source/WebCore/rendering/BorderEdge.h:49 > + BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio); I wonder how much sense it makes to pass Color by reference (rather than by value) these days.
(In reply to comment #2) > (From update of attachment 226826 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review > > > Source/WebCore/rendering/BorderEdge.h:49 > > + BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio); > > I wonder how much sense it makes to pass Color by reference (rather than by value) these days. Good point. I'll make that change.
Created attachment 226830 [details] Patch
Comment on attachment 226830 [details] Patch EWS testing.
Comment on attachment 226830 [details] Patch Clearing flags on attachment: 226830 Committed r165689: <http://trac.webkit.org/changeset/165689>
All reviewed patches have been landed. Closing bug.