Bug 130284 - Rewrite WebHTMLConverter::_getComputedFloat in C++
Summary: Rewrite WebHTMLConverter::_getComputedFloat in C++
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 130274
Blocks: 130227 130287
  Show dependency tree / graph
 
Reported: 2014-03-14 21:39 PDT by Ryosuke Niwa
Modified: 2014-03-17 18:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.63 KB, patch)
2014-03-14 21:42 PDT, Ryosuke Niwa 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-03-14 21:39:21 PDT 
_getComputedFloat should be rewritten in C++ for performance.
Comment 1 Ryosuke Niwa 2014-03-14 21:42:26 PDT 
Created attachment 226805 [details]
Patch
Comment 2 Andreas Kling 2014-03-15 14:42:25 PDT 
Comment on attachment 226805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226805&action=review

> Source/WebCore/platform/mac/HTMLConverter.mm:769
> +        if (Node* parent = node.parentNode())

This is really a ContainerNode*.

> Source/WebCore/platform/mac/HTMLConverter.mm:802
> +        if (Node* parent = node.parentNode())

This is really a ContainerNode*.
Comment 3 Ryosuke Niwa 2014-03-17 18:36:10 PDT 
Committed r165786: <http://trac.webkit.org/changeset/165786>