Bug 130282 - Make some Module class constructors return PassRef.
Summary: Make some Module class constructors return PassRef.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-14 20:19 PDT by Jinwoo Song
Modified: 2014-03-17 00:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.89 KB, patch)
2014-03-14 21:26 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
patch (14.76 KB, patch)
2014-03-16 21:48 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-03-14 20:19:11 PDT 
Make the constructor helpers for the following classes return PassRef instead of
PassRefPtr since they will never return null.
 - GamepadList
 - Geolocation
 - NavigatorContentUtils
 - NetworkInfoConnection
 - Notification
 - NotificationCenter
 - DeviceProximityEvent
Comment 1 Jinwoo Song 2014-03-14 21:26:45 PDT 
Created attachment 226804 [details]
Patch
Comment 2 Jinwoo Song 2014-03-16 21:48:24 PDT 
Created attachment 226879 [details]
patch
Comment 3 Andreas Kling 2014-03-17 00:20:32 PDT 
Comment on attachment 226879 [details]
patch

Sweet! r=me
Comment 4 WebKit Commit Bot 2014-03-17 00:53:05 PDT 
Comment on attachment 226879 [details]
patch

Clearing flags on attachment: 226879

Committed r165723: <http://trac.webkit.org/changeset/165723>
Comment 5 WebKit Commit Bot 2014-03-17 00:53:11 PDT 
All reviewed patches have been landed.  Closing bug.