RESOLVED FIXED 130282
Make some Module class constructors return PassRef. 
https://bugs.webkit.org/show_bug.cgi?id=130282
Summary Make some Module class constructors return PassRef.
Jinwoo Song
Reported 2014-03-14 20:19:11 PDT
Make the constructor helpers for the following classes return PassRef instead of PassRefPtr since they will never return null. - GamepadList - Geolocation - NavigatorContentUtils - NetworkInfoConnection - Notification - NotificationCenter - DeviceProximityEvent
Attachments
Patch (14.89 KB, patch)
2014-03-14 21:26 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
patch (14.76 KB, patch)
2014-03-16 21:48 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-03-14 21:26:45 PDT
Created attachment 226804 [details] Patch
Jinwoo Song
Comment 2 2014-03-16 21:48:24 PDT
Created attachment 226879 [details] patch
Andreas Kling
Comment 3 2014-03-17 00:20:32 PDT
Comment on attachment 226879 [details] patch Sweet! r=me
WebKit Commit Bot
Comment 4 2014-03-17 00:53:05 PDT
Comment on attachment 226879 [details] patch Clearing flags on attachment: 226879 Committed r165723: <http://trac.webkit.org/changeset/165723>
WebKit Commit Bot
Comment 5 2014-03-17 00:53:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.