Bug 130224 - Only export initializeAndGetJSCLLVMAPI from libllvmForJSC.dylib
Summary: Only export initializeAndGetJSCLLVMAPI from libllvmForJSC.dylib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-13 21:15 PDT by Juergen Ributzka
Modified: 2014-03-13 22:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.18 KB, patch)
2014-03-13 21:19 PDT, Juergen Ributzka 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Ributzka 2014-03-13 21:15:24 PDT 
Only export initializeAndGetJSCLLVMAPI from libllvmForJSC.dylib
Comment 1 Juergen Ributzka 2014-03-13 21:19:23 PDT 
Created attachment 226647 [details]
Patch
Comment 2 Mark Rowe (bdash) 2014-03-13 21:30:50 PDT 
Comment on attachment 226647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226647&action=review

> Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:27
>  // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols.

This comment is no longer accurate.
Comment 3 Filip Pizlo 2014-03-13 21:35:36 PDT 
(In reply to comment #2)
> (From update of attachment 226647 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226647&action=review
> 
> > Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:27
> >  // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols.
> 
> This comment is no longer accurate.

Yup.  I will remove it.
Comment 4 Juergen Ributzka 2014-03-13 21:37:40 PDT 
True. I was just looking at the weak binding list for the dylib and I see these operators (new, delete) exported, but that should be correct. The dylib itself only exports the initializeAndGetJSCLLVMAPI.
Comment 5 Filip Pizlo 2014-03-13 21:48:07 PDT 
Landed in http://trac.webkit.org/changeset/165600
Comment 6 Ryosuke Niwa 2014-03-13 22:13:09 PDT 
Looks like this patch broke Mac builds.
Comment 7 Filip Pizlo 2014-03-13 22:13:33 PDT 
(In reply to comment #6)
> Looks like this patch broke Mac builds.

Looking.
Comment 8 Filip Pizlo 2014-03-13 22:15:39 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > Looks like this patch broke Mac builds.
> 
> Looking.

Oh, that's dumb.  Fix coming shortly.
Comment 9 Filip Pizlo 2014-03-13 22:19:44 PDT 
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Looks like this patch broke Mac builds.
> > 
> > Looking.
> 
> Oh, that's dumb.  Fix coming shortly.

Should be fixed in http://trac.webkit.org/changeset/165601!