RESOLVED FIXED 130194
Remove StyleResolver::State::m_parentNode 
https://bugs.webkit.org/show_bug.cgi?id=130194
Summary Remove StyleResolver::State::m_parentNode
Antti Koivisto
Reported 2014-03-13 07:56:09 PDT
We just need the parent style.
Attachments
patch (30.89 KB, patch)
2014-03-13 08:15 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-03-13 08:15:53 PDT
Created attachment 226594 [details] patch
Andreas Kling
Comment 2 2014-03-13 08:56:08 PDT
Comment on attachment 226594 [details] patch r=me! RenderStyle&!
Antti Koivisto
Comment 3 2014-03-13 11:01:35 PDT
https://trac.webkit.org/r165542
Darin Adler
Comment 4 2014-03-13 11:38:30 PDT
To fix optimized builds: "__ZNK7WebCore4Node11renderStyleEv", referenced from: __ZN7WebCore16HTMLTitleElement17textWithDirectionEv in HTMLTitleElement.o __ZNK7WebCore17MediaQueryMatcher16prepareEvaluatorEv in MediaQueryMatcher.o __ZNK7WebCore10StyleMedia11matchMediumERKN3WTF6StringE in StyleMedia.o We need to add includes of NodeRenderStyle.h to HTMLTitleElement.cpp, MediaQueryMatcher.cpp, and StyleMedia.cpp.
Darin Adler
Comment 5 2014-03-13 11:39:17 PDT
I see, Antti did that in http://trac.webkit.org/changeset/165547
Benjamin Poulain
Comment 6 2014-03-13 12:53:52 PDT
(In reply to comment #5) > I see, Antti did that in http://trac.webkit.org/changeset/165547 The bots are still red after r165547.
Antti Koivisto
Comment 7 2014-03-13 13:13:37 PDT
Looks like Benjamin fixed that in https://trac.webkit.org/r165561
Note You need to log in before you can comment on or make changes to this bug.