Bug 130194 - Remove StyleResolver::State::m_parentNode
Summary: Remove StyleResolver::State::m_parentNode
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-03-13 07:56 PDT by Antti Koivisto
Modified: 2014-03-13 13:13 PDT (History)
3 users (show)

See Also:

patch (30.89 KB, patch)
2014-03-13 08:15 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-03-13 07:56:09 PDT
We just need the parent style.
Comment 1 Antti Koivisto 2014-03-13 08:15:53 PDT
Created attachment 226594 [details]
Comment 2 Andreas Kling 2014-03-13 08:56:08 PDT
Comment on attachment 226594 [details]

r=me! RenderStyle&!
Comment 3 Antti Koivisto 2014-03-13 11:01:35 PDT
Comment 4 Darin Adler 2014-03-13 11:38:30 PDT
To fix optimized builds:

  "__ZNK7WebCore4Node11renderStyleEv", referenced from:
      __ZN7WebCore16HTMLTitleElement17textWithDirectionEv in HTMLTitleElement.o
      __ZNK7WebCore17MediaQueryMatcher16prepareEvaluatorEv in MediaQueryMatcher.o
      __ZNK7WebCore10StyleMedia11matchMediumERKN3WTF6StringE in StyleMedia.o

We need to add includes of NodeRenderStyle.h to HTMLTitleElement.cpp, MediaQueryMatcher.cpp, and StyleMedia.cpp.
Comment 5 Darin Adler 2014-03-13 11:39:17 PDT
I see, Antti did that in http://trac.webkit.org/changeset/165547
Comment 6 Benjamin Poulain 2014-03-13 12:53:52 PDT
(In reply to comment #5)
> I see, Antti did that in http://trac.webkit.org/changeset/165547

The bots are still red after r165547.
Comment 7 Antti Koivisto 2014-03-13 13:13:37 PDT
Looks like Benjamin fixed that in https://trac.webkit.org/r165561