Bug 130190 - [EFL] Add option to use separate web process for new window in MiniBrowser
Summary: [EFL] Add option to use separate web process for new window in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 130133 149212
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-13 04:34 PDT by Krzysztof Wolanski
Modified: 2015-09-16 04:02 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (2.94 KB, patch)
2014-03-13 06:51 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
rebased patch (2.63 KB, patch)
2014-03-25 03:30 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
apply suggestions (2.71 KB, patch)
2014-03-26 02:31 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Wolanski 2014-03-13 04:34:30 PDT 
New created window (CTRL + n) will be open in separated web process.
This option is enabled by adding a flag (S/separate-process) with launching 
MiniBrowser.
Comment 1 Krzysztof Wolanski 2014-03-13 06:51:04 PDT 
Created attachment 226590 [details]
proposed patch
Comment 2 Krzysztof Wolanski 2014-03-25 03:30:55 PDT 
Created attachment 227737 [details]
rebased patch
Comment 3 Gyuyoung Kim 2014-03-26 01:45:21 PDT 
Comment on attachment 227737 [details]
rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227737&action=review

> Tools/MiniBrowser/efl/main.c:57
> +static Eina_Bool enable_separated_process = EINA_FALSE;

To be consist with existing variable name. How about using separated_process_enabled ?

> Tools/MiniBrowser/efl/main.c:1982
>      // Enable favicon database.

Please move this comment to 1987 line.
Comment 4 Krzysztof Wolanski 2014-03-26 02:31:44 PDT 
Created attachment 227839 [details]
apply suggestions
Comment 5 Gyuyoung Kim 2014-04-02 03:51:19 PDT 
Comment on attachment 227839 [details]
apply suggestions

LGTM. Thanks.
Comment 6 WebKit Commit Bot 2014-04-02 04:22:59 PDT 
Comment on attachment 227839 [details]
apply suggestions

Clearing flags on attachment: 227839

Committed r166639: <http://trac.webkit.org/changeset/166639>
Comment 7 WebKit Commit Bot 2014-04-02 04:23:02 PDT 
All reviewed patches have been landed.  Closing bug.