WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130190
[EFL] Add option to use separate web process for new window in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130190
Summary
[EFL] Add option to use separate web process for new window in MiniBrowser
Krzysztof Wolanski
Reported
2014-03-13 04:34:30 PDT
New created window (CTRL + n) will be open in separated web process. This option is enabled by adding a flag (S/separate-process) with launching MiniBrowser.
Attachments
proposed patch
(2.94 KB, patch)
2014-03-13 06:51 PDT
,
Krzysztof Wolanski
no flags
Details
Formatted Diff
Diff
rebased patch
(2.63 KB, patch)
2014-03-25 03:30 PDT
,
Krzysztof Wolanski
no flags
Details
Formatted Diff
Diff
apply suggestions
(2.71 KB, patch)
2014-03-26 02:31 PDT
,
Krzysztof Wolanski
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Krzysztof Wolanski
Comment 1
2014-03-13 06:51:04 PDT
Created
attachment 226590
[details]
proposed patch
Krzysztof Wolanski
Comment 2
2014-03-25 03:30:55 PDT
Created
attachment 227737
[details]
rebased patch
Gyuyoung Kim
Comment 3
2014-03-26 01:45:21 PDT
Comment on
attachment 227737
[details]
rebased patch View in context:
https://bugs.webkit.org/attachment.cgi?id=227737&action=review
> Tools/MiniBrowser/efl/main.c:57 > +static Eina_Bool enable_separated_process = EINA_FALSE;
To be consist with existing variable name. How about using separated_process_enabled ?
> Tools/MiniBrowser/efl/main.c:1982 > // Enable favicon database.
Please move this comment to 1987 line.
Krzysztof Wolanski
Comment 4
2014-03-26 02:31:44 PDT
Created
attachment 227839
[details]
apply suggestions
Gyuyoung Kim
Comment 5
2014-04-02 03:51:19 PDT
Comment on
attachment 227839
[details]
apply suggestions LGTM. Thanks.
WebKit Commit Bot
Comment 6
2014-04-02 04:22:59 PDT
Comment on
attachment 227839
[details]
apply suggestions Clearing flags on attachment: 227839 Committed
r166639
: <
http://trac.webkit.org/changeset/166639
>
WebKit Commit Bot
Comment 7
2014-04-02 04:23:02 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug