RESOLVED WONTFIX 130169
[iOS] Use the window size instead of the device size to compute device-width/device-height viewport arguments 
https://bugs.webkit.org/show_bug.cgi?id=130169
Summary [iOS] Use the window size instead of the device size to compute device-width/...
Sam Weinig
Reported 2014-03-12 17:29:07 PDT
[iOS] Use the window size instead of the device size to compute device-width/device-height viewport arguments
Attachments
Patch (3.46 KB, patch)
2014-03-12 17:29 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-03-12 17:29:30 PDT
Created attachment 226564 [details] Patch
Benjamin Poulain
Comment 2 2014-03-12 18:00:59 PDT
Comment on attachment 226564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226564&action=review > Source/WebCore/dom/Document.cpp:2940 > + finalizeViewportArguments(m_viewportArguments, page()->chrome().windowRect().size()); I don't think that works. The value from windowRect() will have the orientation taken into account (and the window size could be smaller than the screen size in some cases).
Benjamin Poulain
Comment 3 2014-03-12 18:08:13 PDT
Comment on attachment 226564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226564&action=review > Source/WebCore/dom/ViewportArguments.cpp:-419 > +void finalizeViewportArguments(ViewportArguments& arguments, FloatSize screenSize) > { > - CGSize screenSize = wkGetViewportScreenSize(); > - As a temporary workaround: What about modifying the screenSize to make it "in portrait", then use that value to update ViewportArguments?
Sam Weinig
Comment 4 2014-03-12 18:53:36 PDT
Comment on attachment 226564 [details] Patch Removing this. I have a better fix.
Note You need to log in before you can comment on or make changes to this bug.