Bug 130162 – [WebGL] WebKit1 + WebKit2 iOS clients should check load policy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Dean Jackson]

Make all WK1 clients and iOS WK2 clients check the WebGL load policy.

[Dean Jackson]

Created attachment 226556 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 226556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226556&action=review

> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h:205
> +    virtual WebCore::WebGLLoadPolicy webGLPolicyForURL(const String&) const override;
> +    virtual WebCore::WebGLLoadPolicy resolveWebGLPolicyForURL(const String&) const override;

I hope the difference between these two is explained in a comment in the base class becuase it's not obvious.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:622
> +#if ENABLE(WEBGL) && !PLATFORM(MAC) && !PLATFORM(IOS)

!PLATFORM(COCOA)?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1767
> +    return WKShouldBlockWebGL() ? WebGLBlockCreation : WebGLAllowCreation;

UNUSED_PARAM() for frame and url?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1772
> +WebCore::WebGLLoadPolicy WebPage::resolveWebGLPolicyForURL(WebFrame* frame, const String& url)
> +{
> +    return WKShouldBlockWebGL() ? WebGLBlockCreation : WebGLAllowCreation;

Ditto.

[Dean Jackson]

(In reply to comment #2)
> !PLATFORM(COCOA)?

Done.

> UNUSED_PARAM() for frame and url?

Just removed them.

[Dean Jackson]

Committed r165514: <http://trac.webkit.org/changeset/165514>