Bug 130135 - Layout Test fast/workers/worker-gc.html is failing
Summary: Layout Test fast/workers/worker-gc.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL: http://build.webkit.org/results/Apple...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-12 09:21 PDT by Jer Noble
Modified: 2014-03-12 11:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2014-03-12 09:56 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-03-12 09:21:03 PDT 
The following layout test is failing on [insert platform]

fast/workers/worker-gc.html

Probable cause:

http://trac.webkit.org/changeset/165458/
Comment 1 Mark Hahnenberg 2014-03-12 09:56:32 PDT 
Created attachment 226522 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-12 10:04:39 PDT 
Comment on attachment 226522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226522&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        so that allocators are notified when with lastChanceToFinalize. This will give them 

s/when//
Comment 3 Jer Noble 2014-03-12 10:08:31 PDT 
FYI, it looks like fast/workers/dedicated-worker-lifecycle.html also started crashing, but unhelpfully without a crash log.
Comment 4 Geoffrey Garen 2014-03-12 10:48:32 PDT 
Comment on attachment 226522 [details]
Patch

r=me
Comment 5 Mark Hahnenberg 2014-03-12 11:18:19 PDT 
Committed r165486: <http://trac.webkit.org/changeset/165486>
Comment 6 Mark Hahnenberg 2014-03-12 11:18:38 PDT 
Comment on attachment 226522 [details]
Patch

Clearing review flag.