Implement the WebView indication for OS X. This way, a debugger can indicates a WebView when choosing a debug target. E.g. the WebView can visibly get a blue highlight like a node highlight.
<rdar://problem/16292728>
Created attachment 226480 [details] [PATCH] Proposed Fix
Comment on attachment 226480 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=226480&action=review > Source/WebCore/inspector/InspectorOverlayPage.js:648 > +function showPageIndication() > +{ > + document.body.classList.add("indicate"); > +} > + > +function hidePageIndication() > +{ > + document.body.classList.remove("indicate"); > +} > + Why not use a property a "showsPageIndication" property here? Is it because it's simpler to call a JS method from C++ code?
(In reply to comment #3) > Why not use a "showsPageIndication" property here? Is it because it's simpler to call a JS method from C++ code? Correct. I was just being consistent with existing code, which keeps things simple. Also, this means that the "dispatch" function is a nice funnel for all incoming messages to the overlay page.
Comment on attachment 226480 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=226480&action=review > Source/WebCore/inspector/InspectorOverlay.cpp:330 > + return m_highlightNode || m_highlightNode || m_indicating || !m_pausedInDebuggerMessage.isNull(); We could remove m_pausedInDebuggerMessage (and friends), it is dead code to us.
<http://trac.webkit.org/changeset/165510>