Bug 130119 - Web Inspector: OS X View Indication
Summary: Web Inspector: OS X View Indication
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-12 00:09 PDT by Joseph Pecoraro
Modified: 2014-03-12 16:40 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (8.81 KB, patch)
2014-03-12 00:15 PDT, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-12 00:09:17 PDT
Implement the WebView indication for OS X. This way, a debugger can indicates a WebView when choosing a debug target. E.g. the WebView can visibly get a blue highlight like a node highlight.
Comment 1 Joseph Pecoraro 2014-03-12 00:09:53 PDT
<rdar://problem/16292728>
Comment 2 Joseph Pecoraro 2014-03-12 00:15:40 PDT
Created attachment 226480 [details]
[PATCH] Proposed Fix
Comment 3 Antoine Quint 2014-03-12 01:14:43 PDT
Comment on attachment 226480 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=226480&action=review

> Source/WebCore/inspector/InspectorOverlayPage.js:648
> +function showPageIndication()
> +{
> +    document.body.classList.add("indicate");
> +}
> +
> +function hidePageIndication()
> +{
> +    document.body.classList.remove("indicate");
> +}
> +

Why not use a property a "showsPageIndication" property here? Is it because it's simpler to call a JS method from C++ code?
Comment 4 Joseph Pecoraro 2014-03-12 11:08:12 PDT
(In reply to comment #3)
> Why not use a "showsPageIndication" property here? Is it because it's simpler to call a JS method from C++ code?

Correct. I was just being consistent with existing code, which keeps things simple. Also, this means that the "dispatch" function is a nice funnel for all incoming messages to the overlay page.
Comment 5 Timothy Hatcher 2014-03-12 12:07:28 PDT
Comment on attachment 226480 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=226480&action=review

> Source/WebCore/inspector/InspectorOverlay.cpp:330
> +    return m_highlightNode || m_highlightNode || m_indicating || !m_pausedInDebuggerMessage.isNull();

We could remove m_pausedInDebuggerMessage (and friends), it is dead code to us.
Comment 6 Joseph Pecoraro 2014-03-12 16:40:41 PDT
<http://trac.webkit.org/changeset/165510>