Bug 130104 - Some images are blank in the rebaseline server UI
Summary: Some images are blank in the rebaseline server UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-11 17:34 PDT by Myles C. Maxfield
Modified: 2014-03-11 20:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2014-03-11 17:35 PDT, Myles C. Maxfield 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-03-11 17:34:05 PDT 
Some layout test images are in a 'retries' folder
Comment 1 Myles C. Maxfield 2014-03-11 17:35:58 PDT 
Created attachment 226452 [details]
Patch
Comment 2 Tim Horton 2014-03-11 19:12:34 PDT 
Comment on attachment 226452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226452&action=review

> Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:283
> +        if (not os.path.isfile(file_path)):

no outer parens
Comment 3 Myles C. Maxfield 2014-03-11 20:48:16 PDT 
http://trac.webkit.org/changeset/165460