Bug 130103 – Improve dom error messages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Improve dom error messages

[Oliver Hunt]

Created attachment 226450 [details]
Patch

[Darin Adler]

Comment on attachment 226450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226450&action=review

> LayoutTests/svg/dom/SVGLengthList-basics-expected.txt:17
> +PASS text1.x.baseVal.initialize(30) threw exception TypeError: Argument 1 ('item') to impl.initialize must be an instance of SVGLength.
> +PASS text1.x.baseVal.initialize('aString') threw exception TypeError: Argument 1 ('item') to impl.initialize must be an instance of SVGLength.
> +PASS text1.x.baseVal.initialize(text1) threw exception TypeError: Argument 1 ('item') to impl.initialize must be an instance of SVGLength.

These messages don’t look so good. Where does the “impl” in “impl.initialize” come from?

> LayoutTests/svg/dom/SVGMatrix-expected.txt:97
> +PASS matrix.multiply(true) threw exception TypeError: Argument 1 ('secondMatrix') to podImpl.multiply must be an instance of SVGMatrix.
> +PASS matrix.multiply(2) threw exception TypeError: Argument 1 ('secondMatrix') to podImpl.multiply must be an instance of SVGMatrix.
> +PASS matrix.multiply('aString') threw exception TypeError: Argument 1 ('secondMatrix') to podImpl.multiply must be an instance of SVGMatrix.
> +PASS matrix.multiply(svgElement) threw exception TypeError: Argument 1 ('secondMatrix') to podImpl.multiply must be an instance of SVGMatrix.

Same question about podImpl.

[Andreas Kling]

This looks like it will bloat our binaries. We should have a function that builds the error messages from its unique parts.

[Oliver Hunt]

Created attachment 226735 [details]
Patch

[Andreas Kling]

Comment on attachment 226735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226735&action=review

r=me, please fix Windows build.

> Source/JavaScriptCore/runtime/Error.h:73
> +    inline EncodedJSValue throwVMTypeError(ExecState* exec, String errorMessage) { return JSValue::encode(throwTypeError(exec, errorMessage)); }

'errorMessage' will have unnecessary ref count churn here.

> Source/WebCore/bindings/js/JSDOMBinding.h:651
> +#define makeDOMBindingsTypeErrorString(...) makeDOMBindingsTypeErrorStringInternal(__VA_ARGS__, (const char*)0)

0->nullptr

[Oliver Hunt]

Committed r165640: <http://trac.webkit.org/changeset/165640>