Bug 130100 - REGRESSION (r165356): [Mac] Multi-part key bindings don't work
Summary: REGRESSION (r165356): [Mac] Multi-part key bindings don't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2014-03-11 16:26 PDT by Alexey Proskuryakov
Modified: 2014-03-12 10:21 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (2.29 KB, patch)
2014-03-11 22:38 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-11 16:26:15 PDT 
If you have this in ~/Library/KeyBindings/DefaultKeyBinding.dict, then pressing Ctrl+m Ctrl+x should insert Esc key glyph:

{
	"^m" = {
		"^x"    = ("insertText:", "\U238B");  /* C-x     escape */ 
	};
}

This is broken because we now pass keyups through -interpretKeyEvents:, and interpreting that resets internal state of key bindings.
Comment 1 Alexey Proskuryakov 2014-03-11 22:38:40 PDT 
Created attachment 226474 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2014-03-12 10:21:07 PDT 
Committed <http://trac.webkit.org/r165477>.

Also changed NO to false - I remembered that the argument was a C++ bool now.