AccessibilityUIElementAtk::y() should access the y local variable, instead of non existing x one.
Created attachment 226442 [details] Patch
Comment on attachment 226442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226442&action=review > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128 > - atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, nullptr, ATK_XY_SCREEN); > + atk_component_get_position(ATK_COMPONENT(m_element.get()), &y, nullptr, ATK_XY_SCREEN); First, sorry, I didn't see it before I landed. I landed the patch at r165463. Anyway, I thought that we should fix it .... nullptr, &y, ATK_XY_SCREEN); If I am wrong, please rebase the patch.
(In reply to comment #2) > (From update of attachment 226442 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226442&action=review > > > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128 > > - atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, nullptr, ATK_XY_SCREEN); > > + atk_component_get_position(ATK_COMPONENT(m_element.get()), &y, nullptr, ATK_XY_SCREEN); > > First, sorry, I didn't see it before I landed. > No worries, I think the important thing is that is now fixed. > I landed the patch at r165463. > > Anyway, I thought that we should fix it > .... nullptr, &y, ATK_XY_SCREEN); > > If I am wrong, please rebase the patch. Actually, you are right. I didn't realize when reviewing it (my bad). Now resolving this as fixed