WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130096
Build fix after
r165439
https://bugs.webkit.org/show_bug.cgi?id=130096
Summary
Build fix after r165439
Thiago de Barros Lacerda
Reported
2014-03-11 16:02:52 PDT
AccessibilityUIElementAtk::y() should access the y local variable, instead of non existing x one.
Attachments
Patch
(1.50 KB, patch)
2014-03-11 16:06 PDT
,
Thiago de Barros Lacerda
mario
: review+
ryuan.choi
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1
2014-03-11 16:06:22 PDT
Created
attachment 226442
[details]
Patch
Ryuan Choi
Comment 2
2014-03-12 03:16:50 PDT
Comment on
attachment 226442
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=226442&action=review
> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128 > - atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, nullptr, ATK_XY_SCREEN); > + atk_component_get_position(ATK_COMPONENT(m_element.get()), &y, nullptr, ATK_XY_SCREEN);
First, sorry, I didn't see it before I landed. I landed the patch at
r165463
. Anyway, I thought that we should fix it .... nullptr, &y, ATK_XY_SCREEN); If I am wrong, please rebase the patch.
Mario Sanchez Prada
Comment 3
2014-03-12 04:15:35 PDT
(In reply to
comment #2
)
> (From update of
attachment 226442
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=226442&action=review
> > > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128 > > - atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, nullptr, ATK_XY_SCREEN); > > + atk_component_get_position(ATK_COMPONENT(m_element.get()), &y, nullptr, ATK_XY_SCREEN); > > First, sorry, I didn't see it before I landed.
> No worries, I think the important thing is that is now fixed.
> I landed the patch at
r165463
. > > Anyway, I thought that we should fix it > .... nullptr, &y, ATK_XY_SCREEN); > > If I am wrong, please rebase the patch.
Actually, you are right. I didn't realize when reviewing it (my bad). Now resolving this as fixed
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug