Bug 130096 - Build fix after r165439
Summary: Build fix after r165439
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-11 16:02 PDT by Thiago de Barros Lacerda
Modified: 2014-03-12 04:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2014-03-11 16:06 PDT, Thiago de Barros Lacerda
mario: review+
ryuan.choi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2014-03-11 16:02:52 PDT
AccessibilityUIElementAtk::y() should access the y local variable, instead of non existing x one.
Comment 1 Thiago de Barros Lacerda 2014-03-11 16:06:22 PDT
Created attachment 226442 [details]
Patch
Comment 2 Ryuan Choi 2014-03-12 03:16:50 PDT
Comment on attachment 226442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226442&action=review

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128
> -    atk_component_get_position(ATK_COMPONENT(m_element.get()), &x,  nullptr, ATK_XY_SCREEN);
> +    atk_component_get_position(ATK_COMPONENT(m_element.get()), &y,  nullptr, ATK_XY_SCREEN);

First, sorry, I didn't see it before I landed.

I landed the patch at r165463.

Anyway, I thought that we should fix it 
.... nullptr, &y, ATK_XY_SCREEN);

If I am wrong, please rebase the patch.
Comment 3 Mario Sanchez Prada 2014-03-12 04:15:35 PDT
(In reply to comment #2)
> (From update of attachment 226442 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226442&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128
> > -    atk_component_get_position(ATK_COMPONENT(m_element.get()), &x,  nullptr, ATK_XY_SCREEN);
> > +    atk_component_get_position(ATK_COMPONENT(m_element.get()), &y,  nullptr, ATK_XY_SCREEN);
> 
> First, sorry, I didn't see it before I landed.
>

No worries, I think the important thing is that is now fixed.

> I landed the patch at r165463.
> 
> Anyway, I thought that we should fix it 
> .... nullptr, &y, ATK_XY_SCREEN);
> 
> If I am wrong, please rebase the patch.

Actually, you are right. I didn't realize when reviewing it (my bad).

Now resolving this as fixed