Make traversing during style resolve more comprehensible by handling before/after pseudo elements explicitly.
Created attachment 226437 [details] patch
Comment on attachment 226437 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=226437&action=review r=me > Source/WebCore/dom/NodeRenderingTraversal.cpp:221 > +Node* firstChildSlow(const Node* node) This code could be made more efficient by exploiting the knowledge that only Elements will have the shouldUseNodeRenderingTraversalSlowPath bit set. > Source/WebCore/dom/NodeRenderingTraversal.h:39 > +Node* lastChild(const Node*); Where is this? > Source/WebCore/dom/NodeRenderingTraversal.h:63 > +inline Node* firstChild(const Node* node) Again, could be better with Element*.
It seems that it was landed but not marked as "RESOLVED FIXED". https://github.com/WebKit/WebKit/commit/d31ae33de07e70eca6498f4f103f7581ba6b9276 and it didn't backed out. I am going to mark this as "RESOLVED FIXED". Thanks!