Bug 130085 - Remove Qt cruft from style checker.
Summary: Remove Qt cruft from style checker.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://qt-project.org/doc/qt-4.8/cont...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-11 05:49 PDT by László Langó
Modified: 2014-03-11 06:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.55 KB, patch)
2014-03-11 05:53 PDT, László Langó 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description László Langó 2014-03-11 05:49:51 PDT 
There is no 'foreach' keyword in c++. That was a Qt feature added in: http://trac.webkit.org/changeset/46113
Qt was removed from WebKit, so we should remove the checks of this keyword from check-webkit-style scripts.
Comment 1 László Langó 2014-03-11 05:53:15 PDT 
Created attachment 226420 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-03-11 05:55:12 PDT 
Comment on attachment 226420 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-03-11 06:32:30 PDT 
Comment on attachment 226420 [details]
Patch

Clearing flags on attachment: 226420

Committed r165450: <http://trac.webkit.org/changeset/165450>
Comment 4 WebKit Commit Bot 2014-03-11 06:32:32 PDT 
All reviewed patches have been landed.  Closing bug.