Bug 130080 - [GTK] Use GMainLoopSource for idle and timeout sources in WebKit1
Summary: [GTK] Use GMainLoopSource for idle and timeout sources in WebKit1
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 130027
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-11 02:47 PDT by Carlos Garcia Campos
Modified: 2014-04-10 23:51 PDT (History)
1 user (show)

See Also:


Attachments
Patch (17.15 KB, patch)
2014-03-11 02:48 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Rebased patch (17.19 KB, patch)
2014-03-21 01:59 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-03-11 02:47:00 PDT
ssia
Comment 1 Carlos Garcia Campos 2014-03-11 02:48:49 PDT
Created attachment 226407 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-11 02:50:47 PDT
Attachment 226407 [details] did not pass style-queue:


ERROR: Source/WebKit/gtk/webkit/webkitwebview.cpp:5337:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2014-03-21 01:59:12 PDT
Created attachment 227401 [details]
Rebased patch
Comment 4 WebKit Commit Bot 2014-03-21 02:01:22 PDT
Attachment 227401 [details] did not pass style-queue:


ERROR: Source/WebKit/gtk/webkit/webkitwebview.cpp:5337:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2014-04-10 23:51:30 PDT
Comment on attachment 227401 [details]
Rebased patch

Clearing flags, there's not WebKit1 GTK port anymore