AX: AccessibilityObject::invalidStatus() is incorrect when aria-invalid="undefined" or whitespace

[James Craig]

AX: AccessibilityObject::invalidStatus() is incorrect when aria-invalid="undefined"

The when the string value "undefined" is used explicitly, it should be treated the same as ariaInvalid.isEmpty()

    // If 'false', empty or not present, it should return false.
    if (ariaInvalid.isEmpty() || equalIgnoringCase(ariaInvalid, invalidStatusFalse))
        return invalidStatusFalse;

Should be:

    // If 'false', empty or not present, it should return false.
    if (ariaInvalid.isEmpty() || equalIgnoringCase(ariaInvalid, invalidStatusFalse) || equalIgnoringCase(ariaInvalid, "undefined"))
        return invalidStatusFalse;

[James Craig]

<rdar://problem/16322420>

[James Craig]

Created attachment 226639 [details]
patch

[James Craig]

[ 16%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/inspector/InspectorResourceAgent.cpp.o
/mnt/eflews/git/webkit/Source/WebCore/accessibility/AccessibilityObject.cpp: In member function 'virtual const WTF::AtomicString& WebCore::AccessibilityObject::invalidStatus() const':
/mnt/eflews/git/webkit/Source/WebCore/accessibility/AccessibilityObject.cpp:1540:103: error: 'stripLeadingAndTrailingHTMLSpaces' was not declared in this scope
make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/accessibility/AccessibilityObject.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

[James Craig]

Created attachment 226640 [details]
patch

[James Craig]

Created attachment 226643 [details]
patch

[chris fleizach]

Comment on attachment 226643 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226643&action=review

> Source/WebCore/ChangeLog:3
> +        AX: AccessibilityObject::invalidStatus() is incorrect when aria-invalid="undefined" or whitespace

i don't see undefined listed in the spec
http://www.w3.org/TR/wai-aria/states_and_properties

> Source/WebCore/accessibility/AccessibilityObject.cpp:1534
> +    DEFINE_STATIC_LOCAL(const AtomicString, invalidStatusGrammar, ("grammar", AtomicString::ConstructFromLiteral));

there's been a desire to stop using statics for things like this. so we might as well change this style if we're going to modify this code.

Let's just use

ASCIILiteral("grammar") when necessary.
See
  https://chromium.googlesource.com/chromium/blink/+/873a4a1f950d7cd7ebe27baba2c0e7e9491190f4%5E%21/#F3
for more examples

[James Craig]

Comment on attachment 226643 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226643&action=review

>> Source/WebCore/ChangeLog:3
>> +        AX: AccessibilityObject::invalidStatus() is incorrect when aria-invalid="undefined" or whitespace
> 
> i don't see undefined listed in the spec
> http://www.w3.org/TR/wai-aria/states_and_properties

From http://www.w3.org/WAI/PF/aria/complete#propcharacteristic_value

The "undefined" value, when allowed on a state or property, is an explicit indication that the state or property is not set. The value is used on states and properties that support tokens, and the "undefined" value is a string that is one of the allowed tokens.

[James Craig]

Created attachment 226739 [details]
patch with review feedback

[James Craig]

Created attachment 226743 [details]
patch merges conflicts with TOT

[chris fleizach]

Comment on attachment 226743 [details]
patch merges conflicts with TOT

we should remove virtual from the method, since subclassers won't override this

[James Craig]

Created attachment 226746 [details]
patch to fix ATK build failure

[James Craig]

Created attachment 226756 [details]
previous patch -virtual

[WebKit Commit Bot]

Comment on attachment 226756 [details]
previous patch -virtual

Rejecting attachment 226756 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[James Craig]

Told you, Sam. ;-)

[WebKit Commit Bot]

Comment on attachment 226756 [details]
previous patch -virtual

Clearing flags on attachment: 226756

Committed r165656: <http://trac.webkit.org/changeset/165656>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.