Bug 130070 - [GTK][CMake] Add HARFBUZZ_INCLUDE_DIRS to WebKit and WebKit2
Summary: [GTK][CMake] Add HARFBUZZ_INCLUDE_DIRS to WebKit and WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jae Hyun Park
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 23:02 PDT by Jae Hyun Park
Modified: 2014-03-11 01:07 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.09 KB, patch)
2014-03-10 23:05 PDT, Jae Hyun Park
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Hyun Park 2014-03-10 23:02:36 PDT
Without HARFBUZZ_INCLUDE_DIRS, you get the following build error.

../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.
Comment 1 Jae Hyun Park 2014-03-10 23:05:15 PDT
Created attachment 226389 [details]
Patch
Comment 2 Martin Robinson 2014-03-11 00:06:08 PDT
Can I see the include tree that the error generates? I'm curious what file is causing this to be included.
Comment 3 Jae Hyun Park 2014-03-11 00:22:56 PDT
(In reply to comment #2)
> Can I see the include tree that the error generates? I'm curious what file is causing this to be included.

In WebKit1:
[2/805] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp.o
FAILED: /home/jaepark/bin/c++   -DBUILDING_GTK__=1 -DBUILDING_WEBKIT -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebKit -DDATA_DIR=\"share\" -DENABLE_3D_RENDERING=1 -DGETTEXT_PACKAGE=\"WebKitGTK-3.0\" -DHAVE_CONFIG_H=1 -DMOZ_X11 -DPACKAGE_LOCALE_DIR=\"/usr/local/share/locale\" -DUSER_AGENT_GTK_MAJOR_VERSION=537 -DUSER_AGENT_GTK_MINOR_VERSION=30 -DWEBKITGTK_API_VERSION_STRING=\"3.0\" -DWTF_PLATFORM_X11=1 -DWTF_USE_3D_GRAPHICS=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DWTF_USE_EGL=1 -DWTF_USE_GLX=1 -DWTF_USE_GSTREAMER -DWTF_USE_LEVELDB=1 -DWTF_USE_OPENGL=1 -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1 -DWTF_USE_WEBAUDIO_GSTREAMER -DWebKit_EXPORTS -DXP_UNIX -std=gnu++0x -fno-omit-frame-pointer -fno-tree-dce -O3 -DNDEBUG -fPIC -I../../Source -I../../Source/JavaScriptCore/ForwardingHeaders -I../../Source/WebKit -I../../Source/WebCore -I../../Source/WebCore/ForwardingHeaders -I../../Source/WebCore/Modules/geolocation -I../../Source/WebCore/Modules/filesystem -I../../Source/WebCore/Modules/mediastream -I../../Source/WebCore/Modules/navigatorcontentutils -I../../Source/WebCore/Modules/networkinfo -I../../Source/WebCore/Modules/webdatabase -I../../Source/WebCore/Modules/websockets -I../../Source/WebCore/accessibility -I../../Source/WebCore/bindings/generic -I../../Source/WebCore/bindings/js -I../../Source/WebCore/bindings -I../../Source/WebCore/bridge -I../../Source/WebCore/bridge/c -I../../Source/WebCore/bridge/jsc -I../../Source/WebCore/css -I../../Source/WebCore/dom -I../../Source/WebCore/dom/default -I../../Source/WebCore/editing -I../../Source/WebCore/fileapi -I../../Source/WebCore/history -I../../Source/WebCore/html -I../../Source/WebCore/html/forms -I../../Source/WebCore/html/shadow -I../../Source/WebCore/inspector -I../../Source/WebCore/loader -I../../Source/WebCore/loader/archive -I../../Source/WebCore/loader/appcache -I../../Source/WebCore/loader/icon -I../../Source/WebCore/loader/cache -I../../Source/WebCore/page -I../../Source/WebCore/page/animation -I../../Source/WebCore/page/scrolling -I../../Source/WebCore/platform -I../../Source/WebCore/platform/animation -I../../Source/WebCore/platform/audio -I../../Source/WebCore/platform/graphics -I../../Source/WebCore/platform/graphics/filters -I../../Source/WebCore/platform/graphics/harfbuzz -I../../Source/WebCore/platform/graphics/harfbuzz/ng -I../../Source/WebCore/platform/graphics/opengl -I../../Source/WebCore/platform/graphics/transforms -I../../Source/WebCore/platform/mediastream -I../../Source/WebCore/platform/mock -I../../Source/WebCore/platform/network -I../../Source/WebCore/platform/sql -I../../Source/WebCore/platform/text -I../../Source/WebCore/plugins -I../../Source/WebCore/rendering -I../../Source/WebCore/rendering/line -I../../Source/WebCore/rendering/shapes -I../../Source/WebCore/rendering/style -I../../Source/WebCore/storage -I../../Source/WebCore/style -I../../Source/WebCore/svg -I../../Source/WebCore/svg/animation -I../../Source/WebCore/svg/graphics -I../../Source/WebCore/svg/properties -I../../Source/WebCore/workers -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/assembler -I../../Source/JavaScriptCore/bytecode -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/disassembler -I../../Source/JavaScriptCore/dfg -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/debugger -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit -I../../Source/JavaScriptCore/llint -I../../Source/JavaScriptCore/parser -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/runtime -I../../Source/WTF -IDerivedSources/JavaScriptCore -IDerivedSources/WebCore -IDerivedSources/ForwardingHeaders -I. -I../../Source/WebCore/platform/network/soup -IDerivedSources -IDerivedSources/webkitdom -IDerivedSources/webkitgtk -IDerivedSources/webkitgtk/webkit -I../../Source/ThirdParty/ANGLE/include/GLSLANG -I../../Source/ThirdParty/ANGLE/src -I../../Source/ThirdParty/ANGLE/include -I../../Source/ThirdParty/ANGLE/include/KHR -I../../Source/WebCore/accessibility/atk -I../../Source/WebCore/platform/cairo -I../../Source/WebCore/platform/geoclue -I../../Source/WebCore/platform/graphics/cairo -I../../Source/WebCore/platform/graphics/gtk -I../../Source/WebCore/platform/graphics/opentype -I../../Source/WebCore/platform/graphics/texmap -I../../Source/WebCore/platform/gtk -I../../Source/WebCore/platform/text/enchant -I../../Source/WebKit/gtk -I../../Source/WebKit/gtk/webkit -I../../Source/WebKit/gtk/WebCoreSupport -I/usr/include/enchant -I../Dependencies/Root/include/libxml2 -I../Dependencies/Root/include/glib-2.0 -I../Dependencies/Root/lib64/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I../Dependencies/Root/include/gtk-3.0 -I../Dependencies/Root/include/atk-1.0 -I../Dependencies/Root/include/at-spi2-atk/2.0 -I../Dependencies/Root/include/gio-unix-2.0 -I../Dependencies/Root/include/cairo -I../Dependencies/Root/include/gdk-pixbuf-2.0 -I../Dependencies/Root/include/freetype2 -I../Dependencies/Root/include/pixman-1 -I/usr/include/pango-1.0 -I/usr/include/libpng12 -I/usr/include/libdrm -I../Dependencies/Root/include/libsoup-2.4    -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings -fno-exceptions -fno-strict-aliasing -MMD -MT Source/WebKit/CMakeFiles/WebKit.dir/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp.o -MF "Source/WebKit/CMakeFiles/WebKit.dir/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp.o.d" -o Source/WebKit/CMakeFiles/WebKit.dir/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp.o -c ../../Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp
In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:33:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:29,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:30,
                 from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33,
                 from ../../Source/WebCore/platform/graphics/texmap/TextureMapper.h:29,
                 from ../../Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:29,
                 from ../../Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:32,
                 from ../../Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:20:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory


In WebKit2:
[12/706] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/DrawingAreaImpl.cpp.o
FAILED: /home/jaepark/bin/c++   -DBUILDING_GTK__=1 -DBUILDING_WEBKIT -DBUILDING_WITH_CMAKE=1 -DDATA_DIR=\"share\" -DENABLE_3D_RENDERING=1 -DENABLE_PLUGIN_PROCESS=1 -DGETTEXT_PACKAGE=\"WebKitGTK-3.0\" -DHAVE_CONFIG_H=1 -DLIBDIR=\"/usr/local/lib/x86_64-linux-gnu\" -DLIBEXECDIR=\"/usr/local/libexec\" -DMOZ_X11 -DPACKAGE_LOCALE_DIR=\"/usr/local/share/locale\" -DUSER_AGENT_GTK_MAJOR_VERSION=537 -DUSER_AGENT_GTK_MINOR_VERSION=30 -DWEBKIT2_COMPILATION -DWEBKITGTK_API_VERSION_STRING=\"3.0\" -DWTF_PLATFORM_X11=1 -DWTF_USE_3D_GRAPHICS=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DWTF_USE_EGL=1 -DWTF_USE_GLX=1 -DWTF_USE_GSTREAMER -DWTF_USE_LEVELDB=1 -DWTF_USE_OPENGL=1 -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1 -DWTF_USE_WEBAUDIO_GSTREAMER -DWebKit2_EXPORTS -DXP_UNIX -std=gnu++0x -fno-omit-frame-pointer -fno-tree-dce -O3 -DNDEBUG -fPIC -I../../Source/WebKit2/PluginProcess/unix -I../../Source/WebKit2/Platform -I../../Source/WebKit2/Shared -I../../Source/WebKit2/Shared/API/c -I../../Source/WebKit2/UIProcess/API/C -I../../Source/WebKit2/WebProcess/InjectedBundle -I../../Source/WebKit2/WebProcess/InjectedBundle/API/c -IDerivedSources -IDerivedSources/InjectedBundle -IDerivedSources/webkitdom -IDerivedSources/ForwardingHeaders -IDerivedSources/ForwardingHeaders/webkit2gtk -IDerivedSources/ForwardingHeaders/webkit2gtk-webextension -IDerivedSources/webkit2gtk/webkit2 -IDerivedSources/webkit2gtk -I../../Source/JavaScriptCore/llint -I../../Source/WebKit2 -I../../Source/WebKit2/NetworkProcess -I../../Source/WebKit2/NetworkProcess/FileAPI -I../../Source/WebKit2/Platform/IPC -I../../Source/WebKit2/PluginProcess -I../../Source/WebKit2/Shared/API -I../../Source/WebKit2/Shared/Authentication -I../../Source/WebKit2/Shared/CoordinatedGraphics -I../../Source/WebKit2/Shared/CoreIPCSupport -I../../Source/WebKit2/Shared/Databases/IndexedDB -I../../Source/WebKit2/Shared/Downloads -I../../Source/WebKit2/Shared/FileAPI -I../../Source/WebKit2/Shared/Network -I../../Source/WebKit2/Shared/Network/CustomProtocols -I../../Source/WebKit2/Shared/Plugins -I../../Source/WebKit2/Shared/Plugins/Netscape -I../../Source/WebKit2/Shared/Plugins/Netscape/x11 -I../../Source/WebKit2/UIProcess -I../../Source/WebKit2/UIProcess/API -I../../Source/WebKit2/UIProcess/API/CoordinatedGraphics -I../../Source/WebKit2/UIProcess/API/cpp -I../../Source/WebKit2/UIProcess/Authentication -I../../Source/WebKit2/UIProcess/CoordinatedGraphics -I../../Source/WebKit2/UIProcess/Downloads -I../../Source/WebKit2/UIProcess/InspectorServer -I../../Source/WebKit2/UIProcess/Launcher -I../../Source/WebKit2/UIProcess/Network -I../../Source/WebKit2/UIProcess/Network/CustomProtocols -I../../Source/WebKit2/UIProcess/Notifications -I../../Source/WebKit2/UIProcess/Plugins -I../../Source/WebKit2/UIProcess/Storage -I../../Source/WebKit2/WebProcess -I../../Source/WebKit2/WebProcess/ApplicationCache -I../../Source/WebKit2/WebProcess/Battery -I../../Source/WebKit2/WebProcess/Cookies -I../../Source/WebKit2/WebProcess/Databases -I../../Source/WebKit2/WebProcess/Databases/IndexedDB -I../../Source/WebKit2/WebProcess/FileAPI -I../../Source/WebKit2/WebProcess/FullScreen -I../../Source/WebKit2/WebProcess/Geolocation -I../../Source/WebKit2/WebProcess/NetworkInfo -I../../Source/WebKit2/WebProcess/IconDatabase -I../../Source/WebKit2/WebProcess/InjectedBundle/API -I../../Source/WebKit2/WebProcess/InjectedBundle/DOM -I../../Source/WebKit2/WebProcess/Launching -I../../Source/WebKit2/WebProcess/MediaCache -I../../Source/WebKit2/WebProcess/Network -I../../Source/WebKit2/WebProcess/Notifications -I../../Source/WebKit2/WebProcess/OriginData -I../../Source/WebKit2/WebProcess/Plugins -I../../Source/WebKit2/WebProcess/Plugins/Netscape -I../../Source/WebKit2/WebProcess/ResourceCache -I../../Source/WebKit2/WebProcess/Storage -I../../Source/WebKit2/WebProcess/WebCoreSupport -I../../Source/WebKit2/WebProcess/WebPage -I../../Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics -I../../Source/WebCore -I../../Source/WebCore/Modules/battery -I../../Source/WebCore/Modules/mediastream -I../../Source/WebCore/Modules/networkinfo -I../../Source/WebCore/Modules/notifications -I../../Source/WebCore/Modules/vibration -I../../Source/WebCore/Modules/webdatabase -I../../Source/WebCore/accessibility -I../../Source/WebCore/bindings/js -I../../Source/WebCore/bindings -I../../Source/WebCore/bridge -I../../Source/WebCore/bridge/jsc -I../../Source/WebCore/css -I../../Source/WebCore/dom -I../../Source/WebCore/dom/default -I../../Source/WebCore/editing -I../../Source/WebCore/fileapi -I../../Source/WebCore/history -I../../Source/WebCore/html -I../../Source/WebCore/html/shadow -I../../Source/WebCore/html/track -I../../Source/WebCore/inspector -I../../Source/WebCore/loader -I../../Source/WebCore/loader/archive -I../../Source/WebCore/loader/icon -I../../Source/WebCore/loader/cache -I../../Source/WebCore/page -I../../Source/WebCore/page/animation -I../../Source/WebCore/page/scrolling -I../../Source/WebCore/page/scrolling/coordinatedgraphics -I../../Source/WebCore/platform -I../../Source/WebCore/platform/animation -I../../Source/WebCore/platform/audio -I../../Source/WebCore/platform/graphics -I../../Source/WebCore/platform/graphics/filters -I../../Source/WebCore/platform/graphics/harfbuzz -I../../Source/WebCore/platform/graphics/harfbuzz/ng -I../../Source/WebCore/platform/graphics/surfaces -I../../Source/WebCore/platform/graphics/texmap -I../../Source/WebCore/platform/graphics/transforms -I../../Source/WebCore/platform/mediastream -I../../Source/WebCore/platform/network -I../../Source/WebCore/platform/sql -I../../Source/WebCore/platform/text -I../../Source/WebCore/plugins -I../../Source/WebCore/rendering -I../../Source/WebCore/rendering/line -I../../Source/WebCore/rendering/shapes -I../../Source/WebCore/rendering/style -I../../Source/WebCore/storage -I../../Source/WebCore/style -I../../Source/WebCore/svg -I../../Source/WebCore/svg/graphics -I../../Source/WebCore/svg/properties -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/ForwardingHeaders -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/assembler -I../../Source/JavaScriptCore/bytecode -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/collector/handles -I../../Source/JavaScriptCore/dfg -I../../Source/JavaScriptCore/disassembler -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit -I../../Source/JavaScriptCore/parser -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/runtime -I../../Source/WTF -IDerivedSources/JavaScriptCore -IDerivedSources/WebCore -IDerivedSources/WebKit2 -IDerivedSources/WebKit2/include -I. -I../../Source -I../../Source/ThirdParty/ANGLE/include/KHR -I../../Source/ThirdParty/ANGLE/include/GLSLANG -I../../Source/WebCore/platform/cairo -I../../Source/WebCore/platform/gtk -I../../Source/WebCore/platform/graphics/cairo -I../../Source/WebCore/platform/graphics/opentype -I../../Source/WebCore/platform/network/soup -I../../Source/WebCore/platform/text/enchant -I../../Source/WebKit2/Shared/API/c/gtk -I../../Source/WebKit2/Shared/Network/CustomProtocols/soup -I../../Source/WebKit2/Shared/Downloads/soup -I../../Source/WebKit2/Shared/gtk -I../../Source/WebKit2/Shared/soup -I../../Source/WebKit2/NetworkProcess/unix -I../../Source/WebKit2/UIProcess/API/C/cairo -I../../Source/WebKit2/UIProcess/API/C/gtk -I../../Source/WebKit2/UIProcess/API/C/soup -I../../Source/WebKit2/UIProcess/API/cpp/gtk -I../../Source/WebKit2/UIProcess/API/gtk -I../../Source/WebKit2/UIProcess/Network/CustomProtocols/soup -I../../Source/WebKit2/UIProcess/Plugins/gtk -I../../Source/WebKit2/UIProcess/gtk -I../../Source/WebKit2/UIProcess/soup -I../../Source/WebKit2/WebProcess/InjectedBundle/API/gtk -I../../Source/WebKit2/WebProcess/gtk -I../../Source/WebKit2/WebProcess/soup -I../../Source/WebKit2/WebProcess/WebCoreSupport/gtk -I../../Source/WebKit2/WebProcess/WebCoreSupport/soup -I../../Source/WebKit2/WebProcess/WebPage/atk -I../../Source/WebKit2/WebProcess/WebPage/gtk -I../../Source/WTF/wtf/gtk -I../../Source/WTF/wtf/gobject -I../Dependencies/Root/include/cairo -I/usr/include/enchant -I../Dependencies/Root/include/libxml2 -I../Dependencies/Root/include/glib-2.0 -I../Dependencies/Root/lib64/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I../Dependencies/Root/include/libsoup-2.4 -I../Dependencies/Root/include/gtk-3.0 -I../Dependencies/Root/include/atk-1.0 -I../Dependencies/Root/include/at-spi2-atk/2.0 -I../Dependencies/Root/include/gio-unix-2.0 -I../Dependencies/Root/include/gdk-pixbuf-2.0 -I../Dependencies/Root/include/freetype2 -I../Dependencies/Root/include/pixman-1 -I/usr/include/pango-1.0 -I/usr/include/libpng12 -I/usr/include/libdrm    -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings -fno-exceptions -fno-strict-aliasing  -include /home/jaepark/Workspace/WebKitGtk/Source/WebKit2/WebKit2Prefix.h -MMD -MT Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/DrawingAreaImpl.cpp.o -MF "Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/DrawingAreaImpl.cpp.o.d" -o Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/DrawingAreaImpl.cpp.o -c ../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:33:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:29,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:30,
                 from ../../Source/WebCore/rendering/style/StyleInheritedData.h:29,
                 from ../../Source/WebCore/rendering/RenderObject.h:37,
                 from ../../Source/WebCore/rendering/RenderElement.h:26,
                 from ../../Source/WebCore/rendering/RenderLayerModelObject.h:26,
                 from ../../Source/WebCore/rendering/RenderBoxModelObject.h:28,
                 from ../../Source/WebCore/rendering/RenderBox.h:26,
                 from ../../Source/WebCore/rendering/RenderReplaced.h:25,
                 from ../../Source/WebCore/rendering/RenderWidget.h:27,
                 from ../../Source/WebCore/rendering/RenderEmbeddedObject.h:26,
                 from ../../Source/WebCore/rendering/RenderSnapshottedPlugIn.h:29,
                 from DerivedSources/ForwardingHeaders/WebCore/RenderSnapshottedPlugIn.h:1,
                 from ../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:32,
                 from ../../Source/WebKit2/WebProcess/WebPage/WebPage.h:41,
                 from ../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:33:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.
ninja: build stopped: subcommand failed.
Comment 4 Martin Robinson 2014-03-11 00:24:58 PDT
Thanks. Strange that no one else requires this so far.
Comment 5 WebKit Commit Bot 2014-03-11 01:07:17 PDT
Comment on attachment 226389 [details]
Patch

Clearing flags on attachment: 226389

Committed r165437: <http://trac.webkit.org/changeset/165437>
Comment 6 WebKit Commit Bot 2014-03-11 01:07:23 PDT
All reviewed patches have been landed.  Closing bug.