RESOLVED FIXED 13007
svn-create-patch doesn't handle UTF files with BOMs as text 
https://bugs.webkit.org/show_bug.cgi?id=13007
Summary svn-create-patch doesn't handle UTF files with BOMs as text
Andrew Wellington
Reported 2007-03-07 15:05:43 PST
svn-create-patch gets confused at strings files because diff isn't treating the files as text (it sees the BOM in the UTF-16 file) Patch to be attached forces all files that svn-create-patch thinks are text to be treated as text.
Attachments
Patch (1.07 KB, patch)
2007-03-07 15:10 PST, Andrew Wellington 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Wellington
Comment 1 2007-03-07 15:10:39 PST
Created attachment 13534 [details] Patch Trivial patch
David Kilzer (:ddkilzer)
Comment 2 2007-03-07 16:40:11 PST
If you create the patch with this change to svn-create-patch, run svn-unapply, then svn-apply, do you end up with the same changes once you're done? I'm wondering if there would be any text conversion funny-business where one two-byte UTF-16 character would get split into two one-byte UTF-8 characters in the process.
Andrew Wellington
Comment 3 2007-03-07 17:08:23 PST
In my testing it appears to work correctly in the situation David described. I just tried adding a line of Japanese text to a file, checking md5 of the file, creating a patch, svn-unapply, svn-apply, checking the md5 of the file. At both points the md5 was identical.
Darin Adler
Comment 4 2007-03-07 17:24:22 PST
Comment on attachment 13534 [details] Patch Can svn-apply and svn-unapply handle these kind of diffs? If not, we need to fix those first.
Darin Adler
Comment 5 2007-03-08 08:58:32 PST
Comment on attachment 13534 [details] Patch r=me
David Kilzer (:ddkilzer)
Comment 6 2007-03-09 16:55:30 PST
Committed revision 20095.
Note You need to log in before you can comment on or make changes to this bug.