WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130063
Remove unused method from BatteryController
https://bugs.webkit.org/show_bug.cgi?id=130063
Summary
Remove unused method from BatteryController
Ryuan Choi
Reported
2014-03-10 19:28:55 PDT
client() is not used since it is introduced.
Attachments
Patch
(1.36 KB, patch)
2014-03-10 19:33 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2014-03-10 19:33:58 PDT
Created
attachment 226372
[details]
Patch
WebKit Commit Bot
Comment 2
2014-03-11 03:09:28 PDT
Comment on
attachment 226372
[details]
Patch Rejecting
attachment 226372
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 226372, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-queues.appspot.com/results/4681445800935424
Ryuan Choi
Comment 3
2014-03-11 04:13:42 PDT
Committed
r165446
: <
http://trac.webkit.org/changeset/165446
>
Ryuan Choi
Comment 4
2014-03-11 04:14:56 PDT
Comment on
attachment 226372
[details]
Patch clearing flags. I landed after fixed changelog which missed "Unreviewed".
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug