Bug 130042 - Web Inspector: console error when clicking AppCache folder tree element
Summary: Web Inspector: console error when clicking AppCache folder tree element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 15:05 PDT by BJ Burg
Modified: 2015-08-04 11:57 PDT (History)
6 users (show)

See Also:


Attachments
Proposed Fix (2.09 KB, patch)
2015-08-01 12:55 PDT, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-03-10 15:05:36 PDT
It's trying to make a content view out of it, but that ain't gonna work.

It's inside a try-catch block, so it doesn't actually break anything.
Comment 1 Timothy Hatcher 2014-03-12 11:48:29 PDT
Sounds like we just need to add the class to the early return in ReourceSidebarPanel._treeElementSelected.

Or come up with a special function on these tree elements (isFolder()?) that we can check.
Comment 2 Brian Burg 2015-08-01 12:55:01 PDT
Created attachment 258014 [details]
Proposed Fix
Comment 3 Joseph Pecoraro 2015-08-04 11:04:29 PDT
Comment on attachment 258014 [details]
Proposed Fix

This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is not a subclass of FolderTreeElement if it acts like a folder.
Comment 4 BJ Burg 2015-08-04 11:21:24 PDT
(In reply to comment #3)
> Comment on attachment 258014 [details]
> Proposed Fix
> 
> This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is
> not a subclass of FolderTreeElement if it acts like a folder.

It probably should be, or we should have a content view for the appcache manifest and change what appears for each frame that uses the same manifest. But there are larger problems with our app cache support (there are no real model objects to speak of; the content view directly unpacks protocol payloads), so I'd defer on further refactoring.
Comment 5 WebKit Commit Bot 2015-08-04 11:57:25 PDT
Comment on attachment 258014 [details]
Proposed Fix

Clearing flags on attachment: 258014

Committed r187872: <http://trac.webkit.org/changeset/187872>
Comment 6 WebKit Commit Bot 2015-08-04 11:57:28 PDT
All reviewed patches have been landed.  Closing bug.