Bug 130034 - REGRESSION (r159218): FrameView::layout() should destroy TemporaryChange<LayoutPhase> before destroying Ref<FrameView>
Summary: REGRESSION (r159218): FrameView::layout() should destroy TemporaryChange<Layo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-03-10 12:26 PDT by Daniel Bates
Modified: 2014-03-10 12:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2014-03-10 12:30 PDT, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-03-10 12:26:51 PDT 
We should always destroy TemporaryChange<LayoutPhase> before destroying Ref<FrameView> in FrameView::layout() so as to ensure that the FrameView exists when we restore the original layout phase value.
Comment 1 Daniel Bates 2014-03-10 12:27:04 PDT 
<rdar://problem/15664288>
Comment 2 Daniel Bates 2014-03-10 12:30:34 PDT 
Created attachment 226330 [details]
Patch
Comment 3 zalan 2014-03-10 12:50:50 PDT 
Comment on attachment 226330 [details]
Patch

Looks good.
Comment 4 Daniel Bates 2014-03-10 12:56:49 PDT 
Committed r165396: <http://trac.webkit.org/changeset/165396>