Bug 130030 - writeBarrier in emitPutReplaceStub is unnecessary
Summary: writeBarrier in emitPutReplaceStub is unnecessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 11:41 PDT by Mark Hahnenberg
Modified: 2014-03-10 11:49 PDT (History)
0 users

See Also:

Attachments
Patch (1.69 KB, patch)
2014-03-10 11:42 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (1.97 KB, patch)
2014-03-10 11:45 PDT, Mark Hahnenberg 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-10 11:41:12 PDT 
We already emit write barriers for each put-by-id when they're first compiled, so it's redundant to emit a write barrier as part of the repatched code.
Comment 1 Mark Hahnenberg 2014-03-10 11:42:28 PDT 
Created attachment 226321 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-10 11:45:43 PDT 
Created attachment 226322 [details]
Patch
Comment 3 Mark Hahnenberg 2014-03-10 11:49:29 PDT 
Committed r165389: <http://trac.webkit.org/changeset/165389>