RESOLVED FIXED130024
[X86_64] Smaller code for add_ir when register is accumulator. 
https://bugs.webkit.org/show_bug.cgi?id=130024
Summary [X86_64] Smaller code for add_ir when register is accumulator.
Andreas Kling
Reported 2014-03-10 09:39:28 PDT
[X86_64] Smaller code for add_ir when register is accumulator.
Attachments
Patch (2.27 KB, patch)
2014-03-10 09:40 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-03-10 09:40:23 PDT
Created attachment 226307 [details] Patch
Michael Saboff
Comment 2 2014-03-10 11:00:49 PDT
Comment on attachment 226307 [details] Patch What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants?
Andreas Kling
Comment 3 2014-03-10 11:17:49 PDT
(In reply to comment #2) > (From update of attachment 226307 [details]) > What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants? The 8 byte immediate variant adds to AL only, and not the upper part of the accumulator.
Andreas Kling
Comment 4 2014-03-10 11:23:51 PDT
Oh oops, I was thinking about 8-bit, not 8 byte. From reading the Intel manual, it looks like the "ADD r/m32,imm8" variant is the shortest possible instruction in that path.
Andreas Kling
Comment 5 2014-03-10 11:50:41 PDT
Comment on attachment 226307 [details] Patch Clearing flags on attachment: 226307 Committed r165390: <http://trac.webkit.org/changeset/165390>
Andreas Kling
Comment 6 2014-03-10 11:50:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.