Bug 130003 - Start splitting CSS Selectors's pseudo types
Summary: Start splitting CSS Selectors's pseudo types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-09 23:08 PDT by Benjamin Poulain
Modified: 2014-03-10 13:54 PDT (History)
11 users (show)

See Also:

Attachments
Patch (54.36 KB, patch)
2014-03-09 23:27 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (58.66 KB, patch)
2014-03-10 00:41 PDT, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-03-09 23:08:42 PDT 
Start splitting CSS Selectors's pseudo types
Comment 1 Benjamin Poulain 2014-03-09 23:27:32 PDT 
Created attachment 226282 [details]
Patch
Comment 2 Andreas Kling 2014-03-09 23:36:06 PDT 
Comment on attachment 226282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226282&action=review

Great that you are working on this!

gtk ews looks unimpressed :|

> Source/WebCore/css/CSSSelector.cpp:304
> +    case CSSSelector::PseudoNot:
> +        if (const CSSSelectorList* selectorList = selector->selectorList())
> +        str.append(selectorList->first()->selectorText());
> +        str.append(')');

Indentation is off here.

> Source/WebCore/css/CSSSelector.cpp:319
> +            if (subSelector != firstSubSelector)
> +            str.append(',');
> +            str.append(subSelector->selectorText());

And here.
Comment 3 Benjamin Poulain 2014-03-10 00:41:08 PDT 
Created attachment 226284 [details]
Patch
Comment 4 Andreas Kling 2014-03-10 01:37:22 PDT 
Comment on attachment 226284 [details]
Patch

r=me
Comment 5 Benjamin Poulain 2014-03-10 13:54:41 PDT 
Committed r165402: <http://trac.webkit.org/changeset/165402>