Bug 129995 - Short-circuit JSGlobalObjectInspectorController when not inspecting.
Summary: Short-circuit JSGlobalObjectInspectorController when not inspecting.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-09 16:36 PDT by Andreas Kling
Modified: 2014-03-13 16:52 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2014-03-09 16:37 PDT, Andreas Kling
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-09 16:36:44 PDT
We're hitting symbolication pretty hard below JSGlobalObjectInspectorController::reportAPIException() on DYEB.
Comment 1 Andreas Kling 2014-03-09 16:37:13 PDT
Created attachment 226261 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-09 17:39:59 PDT
Comment on attachment 226261 [details]
Patch

Should we check m_consoleAgent->enabled() instead? That seems a little closer to the code we're guarding.
Comment 3 Andreas Kling 2014-03-09 18:42:49 PDT
(In reply to comment #2)
> (From update of attachment 226261 [details])
> Should we check m_consoleAgent->enabled() instead? That seems a little closer to the code we're guarding.

SGTM. I'll land with that change :)
Comment 4 Andreas Kling 2014-03-09 18:51:57 PDT
Committed r165357: <http://trac.webkit.org/changeset/165357>
Comment 5 Joseph Pecoraro 2014-03-10 10:22:46 PDT
How were you actually seeing this in DYEB? Any backtrace would do.

reportAPIException is supposed to be used for JSC API exceptions. If we are triggering this frequently, is it on purpose or is it something we are doing in WebCore / Browser level that triggers an exception that we could avoid?
Comment 6 Joseph Pecoraro 2014-03-12 01:16:28 PDT
(In reply to comment #5)
> How were you actually seeing this in DYEB? Any backtrace would do.

Did we find out what the exception actually was?
Comment 7 Andreas Kling 2014-03-13 16:52:24 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > How were you actually seeing this in DYEB? Any backtrace would do.
> 
> Did we find out what the exception actually was?

Nope. :|

Rolled this out in <https://trac.webkit.org/r165575> since now I can't get an exception to show up anymore.