Bug 129982 - RenderElement::valueForLength() callers misuse bool parameter.
Summary: RenderElement::valueForLength() callers misuse bool parameter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 17:19 PST by zalan
Modified: 2014-03-08 18:33 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.41 KB, patch)
2014-03-08 17:40 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-03-08 17:19:38 PST
Do not pass RenderView* as bool (percentage)

LayoutUnit valueForLength(const Length&, LayoutUnit maximumValue, bool roundPercentages = false) const;
Comment 1 zalan 2014-03-08 17:40:07 PST
Created attachment 226242 [details]
Patch
Comment 2 Andreas Kling 2014-03-08 17:41:31 PST
Comment on attachment 226242 [details]
Patch

Wut. r=me
Comment 3 WebKit Commit Bot 2014-03-08 18:33:10 PST
Comment on attachment 226242 [details]
Patch

Clearing flags on attachment: 226242

Committed r165346: <http://trac.webkit.org/changeset/165346>
Comment 4 WebKit Commit Bot 2014-03-08 18:33:12 PST
All reviewed patches have been landed.  Closing bug.