Bug 129977 - [WK2] Improve the network process low memory handler.
Summary: [WK2] Improve the network process low memory handler.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 13:02 PST by Andreas Kling
Modified: 2014-05-23 15:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.04 KB, patch)
2014-03-08 13:02 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (5.20 KB, patch)
2014-03-08 13:13 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (5.17 KB, patch)
2014-03-08 14:36 PST, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-08 13:02:08 PST 
[WK2] Improve the network process low memory handler.
Comment 1 Andreas Kling 2014-03-08 13:02:46 PST 
Created attachment 226229 [details]
Patch
Comment 2 Andreas Kling 2014-03-08 13:13:56 PST 
Created attachment 226230 [details]
Patch
Comment 3 Andreas Kling 2014-03-08 14:36:04 PST 
Created attachment 226236 [details]
Patch

Remove an unnecessary #include
Comment 4 Darin Adler 2014-03-08 16:34:38 PST 
Comment on attachment 226236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226236&action=review

> Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:55
> +#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

I think we should call this PLATFORM(MAC) now instead of !PLATFORM(IOS).

> Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:120
> +    UNUSED_PARAM(critical);

I suggest commenting out the argument name instead of using UNUSED_PARAM, since the former will actually give a compile error if we use the thing we say we’re not using.

> Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:123
> +    RetainPtr<CFURLCacheRef> cache = adoptCF(CFURLCacheCopySharedURLCache());
> +    _CFURLCachePurgeMemoryCache(cache.get());

I think you should do this as a one-liner. No need for the local.
Comment 5 Andreas Kling 2014-03-08 16:44:07 PST 
Committed r165342: <http://trac.webkit.org/changeset/165342>
Comment 6 Jon Lee 2014-03-08 20:15:56 PST 
This broke iOS: bug 129987