RESOLVED FIXED 129975
TextIterator: Use StringView and references rather than pointers 
https://bugs.webkit.org/show_bug.cgi?id=129975
Summary TextIterator: Use StringView and references rather than pointers
Darin Adler
Reported 2014-03-08 11:40:24 PST
TextIterator: Use StringView and references rather than pointers
Attachments
Patch (113.29 KB, patch)
2014-03-08 12:35 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (120.29 KB, patch)
2014-03-08 22:29 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (551.12 KB, application/zip)
2014-03-08 23:04 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (479.86 KB, application/zip)
2014-03-09 01:37 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (483.05 KB, application/zip)
2014-03-09 03:32 PDT, Build Bot 		no flags
Details
Patch (121.71 KB, patch)
2014-03-10 10:04 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-03-08 12:35:03 PST
Created attachment 226226 [details] Patch
Andreas Kling
Comment 2 2014-03-08 13:29:27 PST
Comment on attachment 226226 [details] Patch This looks crashy on EWS. (I thought red EWS was supposed to at least set cq-, causing an e-mail to get sent.)
Darin Adler
Comment 3 2014-03-08 14:36:00 PST
Fixed the build error on GTK and EFL. Now looking into test failures.
Darin Adler
Comment 4 2014-03-08 22:29:53 PST
Created attachment 226250 [details] Patch
Darin Adler
Comment 5 2014-03-08 22:31:26 PST
I was able to reproduce and fix test failures and assertion failures. All the crashes were assertion failures. I fully expect this new patch to be green on all the EWS bots.
Build Bot
Comment 6 2014-03-08 23:04:32 PST
Comment on attachment 226250 [details] Patch Attachment 226250 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5476168429993984 New failing tests: dom/xhtml/level3/core/nodelookupnamespaceuri14.xhtml
Build Bot
Comment 7 2014-03-08 23:04:35 PST
Created attachment 226252 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-03-09 01:37:57 PST
Comment on attachment 226250 [details] Patch Attachment 226250 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5195813902876672 New failing tests: dom/xhtml/level3/core/nodelookupnamespaceuri14.xhtml
Build Bot
Comment 9 2014-03-09 01:37:59 PST
Created attachment 226256 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 10 2014-03-09 03:32:37 PDT
Comment on attachment 226250 [details] Patch Attachment 226250 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5608302561984512 New failing tests: dom/xhtml/level3/core/nodelookupnamespaceuri14.xhtml
Build Bot
Comment 11 2014-03-09 03:32:39 PDT
Created attachment 226258 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Darin Adler
Comment 12 2014-03-10 10:04:01 PDT
Created attachment 226312 [details] Patch
Darin Adler
Comment 13 2014-03-10 10:06:29 PDT
The test failure that we were seeing on the EWS bots was actually a progression, not a regression; I should have updated expected results for that test, and I have now done so.
WebKit Commit Bot
Comment 14 2014-03-10 11:24:17 PDT
Comment on attachment 226312 [details] Patch Clearing flags on attachment: 226312 Committed r165385: <http://trac.webkit.org/changeset/165385>
WebKit Commit Bot
Comment 15 2014-03-10 11:24:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.